Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better env loading e.g. nil from github #11

Open
anthony-chaudhary opened this issue May 19, 2022 · 0 comments
Open

Add better env loading e.g. nil from github #11

anthony-chaudhary opened this issue May 19, 2022 · 0 comments

Comments

@anthony-chaudhary
Copy link
Member

Issue

If no variable is set e.g. ABC is not in env, then env loaders like github actions will set it to various values, e.g. nil eg ABC=nil.
Helm, which will error because it doesn't know nil.

Workarounds known so far are:

  1. Ensure all variables are added to your values.yaml, eg. if you are using github actions then add these new ones to the env and be sure to set them to none
  2. Remove the unused variables from git actions (or your env loader), that will then lean on the helm defaults, which we set to none

Desired state

Helm should do this naturally. If upgrading to v3 doesn't solve it then
we can build some workaround, basically if it's not a recognized value it should default to warning not hard error.

We should fix this in helm since we can't control how values arrive at the values.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant