-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Cita running in Zotero 7 #267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still 640 compiler errors
Note - there is still some different in the typescript config for build errors that I see in VSCode and the eslint errors that appear when running linting. Can hopefully fix at some point...
Just shows some buttons that don't work and the number of citations (which also doesn't work)
… and list of citations
It's still a bit ugly because I have to cast the return values to only be of particular values - should abstract this somewhere
Citations pane title still isn't being shown correctly...
Dominic-DallOsto
force-pushed
the
Dominic-DallOsto/issue171
branch
from
July 7, 2024 21:40
9c4f1b0
to
af01462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
Using the zotero plugin template and update the code to typescript (using esbuild instead of webpack) at the same time.
See #257 for more details