This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Add class identifier to json2typescript class decorator #278
Assignees
Labels
Comments
|
As far as I understand it, anything |
|
Yes, we‘re using the json2typescript in the knore core module, which has his own repository. I will create an issue there. |
|
Ah, I didn't realize that. Thanks for the heads up @subotic @kilchenmann. |
|
Easy |
kilchenmann
pushed a commit
that referenced
this issue
Sep 11, 2018
…#270) * upgrade: Angular 6, with knora-core module from knora-ui for services * changed services imports * enhancement (salsah app): add latest @knora/core version; start with cleaning up code * enhancement: add @knora/action, @knora/search + update @knora/core, @angular/cli, @angular/material and @angular/core + downgrade typescript version to 2.7.0 * build: update @knora/core to 1.0.8-alpha * refactor: change path to @knora/core for services (+ ApiServiceError, ApiServiceResult) and refactor indentation, const declaration and quotes if necessary * refactor (app module): removed unused services which come from @knora/core now * refactor: removed AuthenticationService (replaced by UsersService from @knora/core) * refactor: removed ResourceService, SearchParamsService and SearchService, have been replaced by the one from @knora/core * refactor: removed GravSearchGenerationService, IncomingService, OntologyService, OntologyCacheService, ConvertJSONLD and classes, replaced by the ones from @knora/core, refactor quotes, const declaration and indentation if necessary * refactor (view/properties): change path of imports to @knora/core instead of readPropertyItem or ReadProperties + refactor indentation + delete files: ReadResource, ReadPropertyItem, ReadProperties * refactor : delete ApiService and replace the path in files to @knora/core * refactor (utils.ts): replace AppConfig by KnoraConstants from @knora/core * enhancement (form/edit-resource-class): update the new syntax with .pipe and add the imports * enhancement (FileService): comment method because this service is outdated + refactoring * refactor: remove services in providers (commented) * refactor: change the path of some imports to @knora/core * refactor: replace AppConfig by KnoraConstants from @knora/core * enhancement: change the path to Utils file and update name of RegexUrl interface * enhancement (StoreService): fix bug with 'map' operator * enhancement: replace some variables from AppConfig with the ones from Utils and KnoraConstants in @knora/core * fix: fix bug on specify-property-value component, update path to operator variables from @knora/core and remove it from Salsah * refactor: replace ProgressIndicator component and html tag to the one in @knora/core + refactoring * refactor: change path to @knora/action * refactor: delete Salsah key and reverse pipes, have been replaced by the ones in @knora/action + add kui-sort-button html tag from @knora/action * refactor: delete webapi/knora/admin/, replaced by @knora/core * refactor: delete shared/strings.ts, replaced path to @knora/core * build: update @angular/cli, @angular/core, @angular/material, @knora/core, @knora/action, @knora/search, jdnconvertiblecalendaradapter * refactor: remove pipes imports and components from @knora/action * refactor: remove utils.ts because it's located in @knora/core now * refactor: fix gravsearch service name * enhancement: replace search component by search module * enhancement: import @knora/action in app.module * enhancement / fix: add a provideIn into Injectable decorator and remove services from app.module * refactor: replace AppConfig by KnoraConstants and refactor indentations * refactor: implement @knora/search, remove unnecessary folders * fix: set the lists to List instead of ListInfo * fix: get the resourcesClasses list from the ontologyCacheService instead of resourceTypesService, rename variables and clean file * build: update @knora/search * enhancement: replace the search result method by the knora-ui example * fix (status message service): bug fix (#276) - renamed status-msg-service into status-msg - fix the http get request - update @knora/search package version * fix (salsah tests): fix test isues * fix (status msg): fix status message service * fix (search): update @knora/search package * enhancement (ImageDircetive): update usage of knora constants for file and media server * enhancement (ImageDircetive): update usage of knora constants for file and media server * fix (typescript version): set typescript version to 2.7.0 resolves two items in issue #275 * build: update json2typescript to version 1.0.6 * enhancement (webapi): Add class identifier to json2typescript class decorator. Resolved issue #278 * enhancement (app module): commented out KnoraSchema and AppConfig, replaced by @knora/core * test (view): fix basic tests * enhancement (json2typescript): update json2typescript and @knora/core * docs: update angular 6 * test (view): fix unit tests * enhancement (app module): delete AppConfig and sort-by pipe * test (read value + user): fix path * test: activate it() function * test: define id variable and ngOnInit() * style (search results): fix style issue in search results (padding/margin/scroll) * fix (authentication): add missing authentication service / module * fix (authentication): salsah works now with the latest @knora/authentication module * fix (authentication): fix wrong lifecycle hook implementation * enhancement (admin): tried to fix the ontology resource class issue * fix (test): update travis config * fix (test): fix travis errors * fix (test): fix travis errors * fix (test): fix travis errors * enhancement (resource class): tried to fix the resource class request; but we get wrong iris from the api * fix (search results): fix search results view * enhancement (system view): add AuthGuard to System route * fix (user profile/settings): update user view with new authentication setup * enhancement (interceptor): add correct implementation of interceptor from @knora/authentication * test (salsah app): removed unused tests * test (travis): fix timeout issue * test (travis): fix timeout issue * test (travis): fix timeout issue * test (travis): fix timeout issue * test (travis): fix timeout issue * test (travis): fix timeout issue * test (travis): fix timeout issue * test (travis): fix timeout issue * test (travis): fix timeout issue * test (travis): fix timeout issue * test (travis): fix timeout issue * test (travis): fix timeout issue * enhancement (i18n / lists): fix some issues * test (travis): fix timeout issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Starting from json2typescript v1.0.6, it is strongly recommended to use a class identifier in the class decorator. Example:
The reason: If you minimize large projects, class names may become a single letter. This makes it impossible for json2typescript to show a good debug message. It is also possible that some mapping classes collide.
See also appvision-gmbh/json2typescript#66 or the readme on https://github.com/dhlab-basel/json2typescript/
The text was updated successfully, but these errors were encountered: