Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing classes #65

Open
thomasahle opened this issue Jan 5, 2023 · 1 comment
Open

Optimizing classes #65

thomasahle opened this issue Jan 5, 2023 · 1 comment

Comments

@thomasahle
Copy link

The code

class Test:
    def my_method(self, argument):
        return argument + argument

gets transformed into

class E:
	def my_method(B,argument):A=argument;return A+A

In other words, it seems method names aren't getting replaced, and some (all non-self?) arguments aren't getting renamed either.

I'm sorry if this duplicates issue #7, but I think it's different.

Is the idea that the minifier shouldn't rename "public APIs" like classes?
In my case this is not an issue, so maybe there could be a flag?
Also, the class itself is getting renamed, so maybe this is not the case at all.

@thomasahle
Copy link
Author

Also, this is probably out of scope, but if we consider namedtuples a kind of classes in python, it would be awesome to optimize

from collections import namedtuple
Test = namedtuple('Test', 'arg1 arg2 arg2')
t = Test(1, 2, 3)
print(t.arg1 + t.arg2 + t.arg3)

by renaming the arguments.
Currently it gets minified to:

from collections import namedtuple as E
F=E('Test','arg1 arg2 arg2')
B=F(1,2,3)
print(B.arg1+B.arg2+B.arg3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant