-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Takes too long to sign in #3261
Comments
Hi. Thanks for your valuable input. We will put the configurable session expiration as agenda item on our next planning round, and will give you an update shortly. |
@StefanBerger-DFINITY I'm not aware of any dapp that does this on the IC, so before scheduling, we should inquire if this is secure. |
@peterpeterparker @StefanBerger-DFINITY I know ICPSwap maintain the session for more than 2 days (I don't know how long exactly) and the very popular social wallet vly.money supports configurable session expiration. I use internet identity to sign in vly.money I think either long expiration or configurable expiration can greatly improve user experience! Please enable it. Thanks! |
Would it be possible to calculate the public key/address locally in the frontend (or at least in the backend without a x-net call) based on the principal to speed things up? |
I think that makes absolutely sense. this is a little bit out of context, but maybe you also want to give the user the option to secure transactions with an additional pin/password prompt. I think OpenChat rolled out such feature recently. |
Hi all y'all |
@domwoe I'm not entirely sure, but I remember that the foundation invested some time last year around September when the Alpha version of OISY was created, to implement such a JS derivation without full success. As far as I recall, and if I recall correctly, the amount of work required to achieve such a derivation would be significant.
General context for everyone in this thread: the sign-in has become slower because it now requires a few additional inter-canister update calls. This is due to the foundation's decision to decentralize the signer—'the derivation of the keys'—to a canister controlled by the NNS while retaining control of the OISY backend canister. Additionally, OISY was enhanced with key derivation for Bitcoin, in addition to ETH, which also requires extra update calls. Hence, the sign-in experience is slower. This happens when you sign in for the first time in OISY. Subsequent sign-ins, as long as the derivation remains active—currently set to one hour—do not require upfront derivation. Keys are saved in the browser's cache and are validated asynchronously by a worker to avoid any security issues. Therefore, returning sign-ins with a valid session are still fast enough. Note that I'm not implying there are no possible improvements—I'm strictly sharing information about the why it has become slower. |
I think the "Initializing your wallet" takes too long (~10 seonds). I really hope Oisy wallet can be successful for mass adoption but I fear the long sing in time will make the UX not as good as other wallet solutions. Is it possible to make it faster? Also I think letting user configure their own session expiration helps. I personally would like to make the session expires in 7 days or something like that so that I won't need to wait to sign in every time when I want to trade. Thanks!
](url)The text was updated successfully, but these errors were encountered: