Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proposal ballots for voting state #5559

Merged
merged 10 commits into from
Oct 4, 2024

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Oct 1, 2024

Motivation

There are multiple reports from users who can’t vote. We believe the root cause of this issue is the 100-ballot limit for neurons. If a user has voted on more than 100 proposals (a likely scenario over a 4-day period), they don’t receive ballots for proposals they’ve already voted on, which remain technically votable due to this limit. The suggested solution is to switch from using neuron ballots to proposal ballots when calculating the votable state.

The utilities have already been already updated in ic-js - dfinity/ic-js#725

Changes

  • npm run upgrade:next
  • Update the displayed votable neurons on proposal changes as well, since we use the proposal ballots to determine the neurons’ voting state.

Tests

  • Updated.
  • Manually
  1. Created 100+ proposals.
  2. Voted on them.
  3. Ensured that some of them were still displayed as votable (due to the recentBallots limit).
  4. Switched to the utilities that rely on the proposal ballots.
  5. Verified that all the proposals previously displayed as votable (despite having already been voted on) were now displayed as voted.

Todos

  • Add entry to changelog (if necessary).

@mstrasinskis mstrasinskis changed the title Take the proposal into account to trigger updating the votable neuron… Use proposal ballots for voting state Oct 1, 2024
@mstrasinskis mstrasinskis marked this pull request as ready for review October 2, 2024 08:15
@mstrasinskis mstrasinskis requested a review from a team as a code owner October 2, 2024 08:15
@mstrasinskis mstrasinskis added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 6ad5330 Oct 4, 2024
30 checks passed
@mstrasinskis mstrasinskis deleted the mstr/proposal-ballots-for-voting-state branch October 4, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants