Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(https-outcalls): Increase allowed header size limit for HTTP/2 requests #2292

Merged
merged 6 commits into from
Oct 28, 2024

Conversation

DSharifi
Copy link
Member

After enabling h/2 with outcalls we had a regression where responses to https outcalls with headers greated than 16KB would fail. In hyperium/hyper-util#154 (comment) hyper-util exposes a method to increase the header response limit.

This PR increases the limit to 52KiB, above 48KiB in the spec, to not block this weeks release in case the spec-compliance tests have any headers hardcoded that can break the test. We can reduce this limit closer to 48KiB in the future.

@github-actions github-actions bot added the fix label Oct 28, 2024
@DSharifi DSharifi changed the title fix: Increase allower header size limit to meet ic spec fix: Increase allowed header size limit to meet the IC-spec Oct 28, 2024
@DSharifi DSharifi marked this pull request as ready for review October 28, 2024 15:04
@DSharifi DSharifi requested review from a team as code owners October 28, 2024 15:04
@DSharifi DSharifi enabled auto-merge October 28, 2024 15:05
@DSharifi DSharifi changed the title fix: Increase allowed header size limit to meet the IC-spec fix(https-outcalls): Increase allowed header size limit for HTTP/2 requests to meet the IC-spec Oct 28, 2024
@DSharifi DSharifi changed the title fix(https-outcalls): Increase allowed header size limit for HTTP/2 requests to meet the IC-spec fix(https-outcalls): Increase allowed header size limit for HTTP/2 requests Oct 28, 2024
@DSharifi DSharifi self-assigned this Oct 28, 2024
@DSharifi DSharifi added this pull request to the merge queue Oct 28, 2024
Merged via the queue into master with commit ec12a4e Oct 28, 2024
25 checks passed
@DSharifi DSharifi deleted the dsharifi/increase-header-size-limit branch October 28, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants