Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: downgrade agent-js ^2.0.0 #726

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Oct 7, 2024

Motivation

We want to allow the consumers to decide what compatible version of agent-js v2 they wish to use.

Notes

We also need to downgrade agent-js in NNS dapp.
dfinity/nns-dapp#5584

Changes

  • Downgrade to ^2.0.0

Signed-off-by: David Dal Busco <[email protected]>
@peterpeterparker peterpeterparker requested review from a team as code owners October 7, 2024 15:58
Copy link
Contributor

github-actions bot commented Oct 7, 2024

size-limit report 📦

Path Size
@dfinity/ckbtc 7.99 KB (0%)
@dfinity/cketh 3.53 KB (0%)
@dfinity/cmc 1.3 KB (0%)
@dfinity/ledger-icrc 4.17 KB (0%)
@dfinity/ledger-icp 15.43 KB (0%)
@dfinity/nns 36.23 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.87 KB (0%)
@dfinity/utils 4.5 KB (0%)
@dfinity/ic-management 3.01 KB (0%)

Copy link
Collaborator

@dskloetd dskloetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterpeterparker peterpeterparker merged commit 4bf2d17 into main Oct 7, 2024
11 checks passed
@peterpeterparker peterpeterparker deleted the build/downgrade-agent-js branch October 7, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants