fix bug where govtable falls over if width_overwrite = NULL #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenisayshi
changed the title
sarahmwong
requested changes
Dec 6, 2024
There was a problem hiding this comment.
Thanks Jeni! Fix looks good to me, thank you for adding tests too. Please can we add a line in at the top of the function documentation to clarify that if using width_overwrite, the specified widths for columns need to add up to one? Will just need the R documentation running off again and then happy to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapped the custom table width code to only run if width_overwrite is not null and added tests