Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar nav #100

Merged
merged 24 commits into from
Sep 6, 2024
Merged

Sidebar nav #100

merged 24 commits into from
Sep 6, 2024

Conversation

jenisayshi
Copy link
Contributor

No description provided.

@jenisayshi jenisayshi requested a review from cjrace September 4, 2024 15:42
Copy link
Collaborator

@cjrace cjrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of quick comments plus:

  1. Could we add an example to the readme with a screenshot for how to do this with the sub page links (and without)?
  2. A bit cheeky, but while adding an example to the readme would you have time to review and update some of the other screenshots too? I know the accordions have changed in appearance now, and the tags have too, there might be more
  3. When you click on one of the main contents links (not the sub ones) the page focus jumps up slightly jarringly to the very top of the page, is there a way to make it focus your screen to the main header of the page you've clicked to go to instead? (if that makes sense?)

R/contents_links.R Outdated Show resolved Hide resolved
R/contents_links.R Show resolved Hide resolved
@jenisayshi jenisayshi merged commit 4ca8877 into development Sep 6, 2024
5 checks passed
@jenisayshi jenisayshi deleted the sidebar-nav branch September 6, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants