From a4224bfc867ff51194522d6468b89dcdf80dca44 Mon Sep 17 00:00:00 2001 From: Cam Race <52536248+cjrace@users.noreply.github.com> Date: Fri, 6 Dec 2024 09:20:55 +0000 Subject: [PATCH] add codeowners --- .github/CODEOWNERS | 12 ++++++++++++ .github/CONTRIBUTING.md | 4 ++++ 2 files changed, 16 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000..b371b90 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,12 @@ +# These owners will be the default owners for everything in +# the repo. Unless a later match takes precedence, +# these will always be requested as reviewer when someone +# opens a pull request. +* @cjrace @sarahmwong + + +# Keep individual file lines at the end so they can take +# precedence over more generic rules above +# Putting Cam as owner so that if there's any changes to +# our link text list, he can update EES to match +data-raw/bad_link_text.R @cjrace \ No newline at end of file diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index bd49531..e516e4a 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -16,6 +16,10 @@ Once a pull request is reviewed and ready to be merged in, all commits in the PR The `master` branch acts as the development version of the package for users, releases of stable package versions to CRAN will be made by the maintainers when they feel it is appropriate to do so. +### Code owners + +We make use of [GitHub's CODEOWNERS file](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners) to set default reviewers for the repo and for specific parts of the code. + ## CSS changes All changes made to the main `inst/www/css/govuk-frontend-norem.css` file should be logged in the `css_changes.md` file, this way they can easily be reapplied whenever the CSS assests from GOV.UK are updated.