New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularise and tidy up CSS #102

Open

cjrace opened this issue Dec 8, 2024 · 0 comments

Labels

Milestone

Accessibility UI ...

Contributor

cjrace commented Dec 8, 2024

We currently have one long custom CSS to style the dashboard. Though we should tidy this up:

Remove all unnecessary CSS

Make use of what is already attached in shinyGovstyle from the GDS design system
Modularise into CSS for specific components
Move any CSS for specific components into the dfeshiny package, attached to the specific components

Remove as many instances of !important as we can

!important is generally bad practice, and can usually be avoided by using the appropriate specificity for the CSS assignments

cjrace added the enhancement label

cjrace added this to the Accessibility UI refresh milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment