Eesp/workflows maintenance Nov 24 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-attainment-and-single-year-entries Dev ks5 timeseries attainment and single year entries
Syncing latest updates in main to the development branch
…-attainment-and-single-year-entries Updated R packages for Dev ks5 timeseries attainment and single year entries
…s-attainment-and-single-year-entries updated mgcv
…s-attainment-and-single-year-entries updated renv, global and server
…s-attainment-and-single-year-entries Revised dashboard
…s-attainment-and-single-year-entries updated global
…s-attainment-and-single-year-entries Dev ks5 timeseries attainment and single year entries
rmbielby
changed the base branch from
development
to
dev-ks5-timeseries-attainment-and-single-year-entries
…into eesp/workflows-maintenance-nov-24
rmbielby
merged commit 5c1f4ac
into
dev-ks5-timeseries-attainment-and-single-year-entries
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Updating the workflow scripts for Nov 2024 publication.
I've also migrated the UI tests to shinytest2 quickly and updated the disconnect message to the dfeshiny controlled version.
Pull request checklist
Please check if your PR fulfils the following:
run_tests_locally())tidy_code())What is the current behaviour?
Workflow scripts are all failing due to being fixed to older R version.
What is the new behaviour?
Deploy scripts and test scripts should now work...
Note though that the UI (shinytest) test won't work on the server until the new data has been pushed as it tries to run the dashboard, but can't because it doesn't have the data. It would be worth double checking it does work by running
shinytest2::run_tests()locally to update the snapshots (but best not to push yet as those snapshots will likely store some small amounts of the new data).Anything else
Doesn't look like the UI tests are particularly extensive, would be good to review and add to them where necessary.