Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for standard requirements workflow #58

Open
rmbielby opened this issue Oct 17, 2024 · 1 comment
Open

Check for standard requirements workflow #58

rmbielby opened this issue Oct 17, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@rmbielby
Copy link
Contributor

Describe the solution you'd like

We could do with a workflow script that ensures a public dashboard is meeting the necessary requirements (as much as we can reasonably regulate via a workflow). I'm thinking:

  • ensure the necessary cookie control elements are present
  • ensure an accessibility statement is present
  • ensure the support_links panel is present

In addition, it might be worth considering if certain parameters are filled in appropriately (although I suspect we'll have plenty of these covered just by mandating the above panels are present and their associated validation):

  • google_analytics_key
  • title
  • name of dashboard in cookies
  • ...

Describe alternatives you've considered

Thought about a commit hook, but I like it the idea of something being added to the PR testing so that we've got clearer sight of what's going on.

Additional context

This follows on from the Attendance dashboard team removing the necessary cookie control code from their server.R script and breaking that functionality for 3 weeks.

@rmbielby rmbielby added the enhancement New feature or request label Oct 17, 2024
@cjrace
Copy link
Contributor

cjrace commented Oct 17, 2024

I like this, would be interesting to think about whether there's anything we do to automate monitoring as a GitHub organisation when this workflow is run and whether its last run on the default branch of a given repo passed or failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants