Bugfix/cookies panels vignette #86
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -72,7 +72,7 @@ | |||
| expect_gt( | |||
| grep( | |||
| paste0( | |||
| "<a href=\"https://shiny.posit.co/\" target=\"_blank\" rel=\"noopener no", | |||
| "<a href=\"https://shiny.posit.co/\" class=\"govuk-link\" target=\"_blank\" rel=\"noopener no", | |||
Check notice
Code scanning / lintr
Lines should not be more than 100 characters. This line is 103 characters. Note test
| # Left navigation ========================================================= | ||
| shinyGovstyle::gov_box( | ||
|
|
||
| # fill = FALSE |
Check notice
Code scanning / lintr
Commented code should be removed. Note test
| ) | ||
|
|
||
| # shiny::observeEvent(input$`cookies_banner-cookies_link`, { | ||
| # bslib::nav_select("left_nav", selected = "cookies_panel") |
Check notice
Code scanning / lintr
Commented code should be removed. Note test
|
Looks like you haven't run I've just run that and then moved the resulting www/ folder containing the javascript code to tests/www/ and the buttons work fine after that. |
Brief overview of changes
Still a WIP... Latest notes to myself (this PR is not ready to review!):
Updated the tests/test_dashboard to use bslib, all seems fine there.
However, when trying to add code for a bslib example, I've gotten stuck. There's two example apps that should work, but I'm not sure do (or at least I may have missed something...). @rmbielby could you take a look?
shiny::runApp("tests/example_testing_plain.R")shiny::runApp("tests/example_testing_bslib.R")(tried all combinations of custom ids and default ids and can't seem to get it working, it works in the tests/test_dashboard though!)
Rest of notes...
Can use bslib::nav_select(), though bslib tab sets seem to work fine with shiny::updateTabsetPanel too, so that isn't the issue and is a nice thing for us meaning we can support bslib and not from the existing function in theory.
Clean up tasks to do before publishing / getting review
Why are these changes being made?
I tried to follow along with the existing vignette on the apps provider dashboard and couldn't successfully add cookies tracking into it.
Detailed description of changes
Coming soon
Additional information for reviewers
Coming soon
Issue ticket number/s and link
Resolves #53