Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on blueprint book creation, also refactor get_blueprint #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix crash on blueprint book creation, also refactor get_blueprint #41

wants to merge 2 commits into from

Conversation

sparr
Copy link

@sparr sparr commented Aug 23, 2020 •
edited
Loading

LuaItemStack.active_index is 1 (not nil or 0) for a brand new empty blueprint book, which led to a crash when that index in the inventory was accessed.

While I was in there I also refactored get_blueprint from recursive to iterative.

Fixes #39

@morsk
Copy link

morsk commented Aug 28, 2020

I just tried this and it worked for me.

@junhinhow
Copy link

Work's like a charm for me too...

@rpdelaney rpdelaney mentioned this pull request Oct 11, 2020
Open
@rpdelaney
Copy link

See also #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating Blueprint Book causes crash
4 participants
@sparr @morsk @junhinhow @rpdelaney