Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs Rework #613

Open
Dammshine opened this issue Mar 17, 2024 · 0 comments
Open

Tabs Rework #613

Dammshine opened this issue Mar 17, 2024 · 0 comments

Comments

@Dammshine
Copy link
Contributor

You can find it in client/src/components/Tabs

Basic jest is, the last year subcom/director implements Tabs, Tab component. Tab is always inside Tabs and Tab has a prop called label that is no-way getting type annotate correctly/

interface TabProps {
  // TODO: Fix this
  // eslint-disable-next-line react/no-unused-prop-types
  label: string;
  children: ReactNode;
}

The current implementation appears to be unnecessarily complex, hard to change in future.

Refactor this,

  1. Refactor Tabs to assume it's internal element has Tab type
  2. Tab type can leave as it is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant