Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End python 2 support #676

Open
MaxLeiter opened this issue Jul 21, 2017 · 2 comments
Open

End python 2 support #676

MaxLeiter opened this issue Jul 21, 2017 · 2 comments
Labels
question

Comments

@MaxLeiter
Copy link
Contributor

Leads to annoying CI failures such as: https://travis-ci.org/devsnd/cherrymusic/jobs/255910887

honestly, just switch to python 3
@devsnd
Copy link
Owner

devsnd commented Jul 21, 2017

I agree (see here #280).

But before we decide something like that using a gut feeling, maybe we should check if the most popular distros (especially for raspberry pi and the like) already switched to python 3 by default, etc. This might be a more reasonable thing to act upon before we break everybodies CM setup!

@MaxLeiter
Copy link
Contributor Author

Ah, I actually was mostly in favor of this due to the failing tests, but now I see those are due to pypy -- any chance you can remove/fix that test, @devsnd?

tilboerner added a commit that referenced this issue Sep 16, 2017
@tilboerner
Fix pypy tests (#676)
aa4eea1 
Explicitly close all db cursors in sqlitecache.py, so we can commit to db
even if the cursor objects have not been garbage collected and thus been
implicitly closed.

(Other Python implementations like PyPy do not mimic CPython's behavior of
immmediately garbage collecting stale objects, as it's just an implementation
detail and not part of the language spec.)
@tilboerner tilboerner mentioned this issue Sep 16, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devsnd @MaxLeiter