Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STARWARS API has changed #11

Open
akselbork opened this issue May 27, 2024 · 6 comments · May be fixed by #14 or #12
Open

STARWARS API has changed #11

akselbork opened this issue May 27, 2024 · 6 comments · May be fixed by #14 or #12
Assignees
Labels
confirmed An issue that has been investigated and verified by the editors. external An external bug is causing an issue.

Comments

@akselbork
Copy link

akselbork commented May 27, 2024

The Uri for the Starwars data has changed. so the link used in all examples does not exists anymore

The new API is located here

https://swapi.dev/

@TheFreeman193
Copy link
Collaborator

Hi there, thanks for letting us know about this.

It looks like the new API has slightly different result encapsulation with pagination which will require modification of the example code.

We'll update the examples here and in the manuscript so that we can push an update to LeanPub.

@TheFreeman193 TheFreeman193 added confirmed An issue that has been investigated and verified by the editors. external An external bug is causing an issue. labels May 27, 2024
@akselbork
Copy link
Author

Have tried to rewrite it, so it could be used for the other site, but having some issues

so thank you for responding and keep up the good work. Find the book very useful and informative even after doing PS since Verizon 1.0

@TheFreeman193 TheFreeman193 self-assigned this May 27, 2024
@TheFreeman193 TheFreeman193 linked a pull request May 27, 2024 that will close this issue
@mattcorr
Copy link
Collaborator

I might just mention that i used swapi.dev as inspiration for my own demo site. The API is not similar but not exactly the same.

@TheFreeman193
Copy link
Collaborator

I'm starting to wonder, since we're only requesting buckets of data and not utilising queries etc., if it might be better we just host it statically on GitHub? That way we could tweak the data to match the existing code (i.e. restore the id member for all objects and use IDs for data linking instead of URLs) and it'd have the same reliability parameters as the Extras repo. Thoughts?

@TheFreeman193
Copy link
Collaborator

@mattcorr @akselbork I'm trialling a static API using GitHub pages that will need minimal changes to the example code and doesn't need domain, SSL certificate maintenance etc.

https://thefreeman193.github.io/mita-swapi

Required changes for this approach are at #14.

Can you folks take a look at, test, and try to break it? Cheers. 😁

@TheFreeman193
Copy link
Collaborator

For interested parties, we are currently looking at whether we can restore the API at its original location so as not to confuse readers of the hard copies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed An issue that has been investigated and verified by the editors. external An external bug is causing an issue.
Projects
None yet
3 participants