Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links not visible in HTML pages #31

Open
vladak opened this issue Apr 28, 2024 · 2 comments
Open

links not visible in HTML pages #31

vladak opened this issue Apr 28, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@vladak
Copy link
Member

vladak commented Apr 28, 2024

The links in the HTML documents rendered for the notes branch are visible only when hovering.

This might have been introduced with the recent token change for the grip tool used to generate HTML.

@vladak vladak added the bug Something isn't working label Apr 28, 2024
@vladak
Copy link
Member Author

vladak commented Apr 28, 2024

In Firefox the links are visible when selecting View -> Page Style -> No style, so this is likely something present in CSS. Indeed, the a.hover has text-decoration: underline;.

@vladak
Copy link
Member Author

vladak commented Nov 18, 2024

We should consider replacing the Markdown rendering currently done via grip (which uses Github markdown RESTful API) with something else. Recently I stumbled across https://github.com/jackyzha0/quartz which I believe renders the content locally; also it is usable with Github pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant