Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate attempts blocks providing final feedback, stranding assignment as Waiting for feedback #1301

Open
torgeirl opened this issue May 28, 2024 · 1 comment

Comments

@torgeirl
Copy link
Collaborator

Description
If an examiner by mistake grants more than one new attempt and then provides feedback, the student group is stranded at waiting for feedback on the last attempt given after the deadline expires while the examiner is prevented from given further feedback since «Feedback is already published!».

My guess is that the first feedback provided is given to the oldest open attempt, but that the save_object() if-else looks at something else.

Workaround
Using Simple bulk feedback an examiner is able to give the student group a grade, and that will also change the status from Waiting for feedback to Corrected.

@torgeirl torgeirl added this to the Devilry 6.4 milestone May 28, 2024
@torgeirl torgeirl changed the title Duplicate attempts blocks providing feedback, stranding assignment as Waiting for feedback Duplicate attempts blocks providing final feedback, stranding assignment as Waiting for feedback May 28, 2024
@Levijatan
Copy link
Collaborator

Yup the feedback was given to the oldest attempt. Could not find an east way to make sure that the feedback gets to the newest attempt, so ended up with changing how new attempts are made to check if there is no feedback published it moves the deadline rather then creating a new attempt. Commited in 326a5d4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants