Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeleteView uses POST (not DELETE) and its handling should therefore be moved to form_valid() #1293

Open
torgeirl opened this issue Apr 19, 2024 · 1 comment
Milestone

Comments

@torgeirl
Copy link
Collaborator

Django warning: DeleteViewCustomDeleteWarning: DeleteView uses FormMixin to handle POST requests. As a consequence, any custom deletion logic in GroupCommentDeleteView.delete() handler should be moved to form_valid()

@torgeirl torgeirl added this to the Devilry 6.4 milestone Apr 19, 2024
@Levijatan
Copy link
Collaborator

Fixed this in 6ee45c5. Moved logic to form_valid() and overwrote delete() with delete() from grandparent since delete() was changed in parent DeleteView from cradmin_legacy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants