-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update library version and fix revision usage in cache samples #188
Conversation
* Update gh actions for nodejs16 Signed-off-by: thepetk <[email protected]> * Further updates on gh actions versions Signe-off-by: thepetk <[email protected]> Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 35.93% 35.93%
=======================================
Files 7 7
Lines 1347 1347
=======================================
Hits 484 484
Misses 816 816
Partials 47 47 ☔ View full report in Codecov by Sentry. |
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
@@ -11,4 +11,4 @@ metadata: | |||
- Go | |||
version: 2.1.0 | |||
parent: | |||
uri: https://registry.devfile.io/devfiles/go/2.1.0 | |||
uri: https://raw.githubusercontent.com/devfile/registry/main/stacks/go/2.1.0/devfile.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this change mean to be pushed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the test was failing due to the previous link. It seems that due to recent changes the URI of this format is not supported anymore. The reason is we are now using DownloadGitRepoResources which expects a git provider link instead of the registry one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
/generator
/server
What does does this PR do / why we need it:
Update devfile library version
This PR updates the version of
github.com/devfile/library/v2
tov2.2.1
. One of the new features of library, will let us accept two different components using the same port. This way we can introduce new sample versions that will have consistent ports (using 8080 port).With the current version of library the registry build fails as the validation of the devfile fails because of using twice the same port for different components. Trace:
Use git.revision instead of git.checkoutFrom.revision
The PR also uses replaces the usage of
git.checkoutFrom.revision
inside thecache_samples.sh
by using thegit.revision
which is the correct field according theGit
schema: https://github.com/devfile/registry-support/blob/main/index/generator/schema/schema.go#L224Which issue(s) this PR fixes:
Partially fixes devfile/api#1112
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: