Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registry's nightly run check for RHTAP #1372

Closed
thepetk opened this issue Dec 6, 2023 · 5 comments · Fixed by devfile/registry#257
Closed

Fix registry's nightly run check for RHTAP #1372

thepetk opened this issue Dec 6, 2023 · 5 comments · Fixed by devfile/registry#257
Assignees
Labels
area/ci area/registry Devfile registry for stacks and infrastructure area/test-automation Test automation for devfile specification and library kind/bug Something isn't working

Comments

@thepetk
Copy link
Contributor

thepetk commented Dec 6, 2023

Which area this feature is related to?

/kind bug

Which area this bug is related to?

/area ci
/area registry
/area test-automation

Bug Summary

Describe the bug:

The registry nightly run is failing after the completion of #1112 (more details here: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-devfile-registry-main-v4.12-rhtap-nightly-devfile-compatibility/1732007644123631616).

This is because the tests/rhtap/rhtap_test.go calls sampleEntry.Git.Remotes.Origin which has now changed.

To Reproduce:

Check the failing test here: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-devfile-registry-main-v4.12-rhtap-nightly-devfile-compatibility/1732007644123631616

Expected behavior

The test should be passing

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-devfile-registry-main-v4.12-rhtap-nightly-devfile-compatibility/1732007644123631616

Additional context

We should try to test the default version of the sample and get the git remote from there.

Any workaround?

Described in the additional context

Suggestion on how to fix the bug

Described in the additional context

@openshift-ci openshift-ci bot added kind/bug Something isn't working area/ci area/registry Devfile registry for stacks and infrastructure area/test-automation Test automation for devfile specification and library labels Dec 6, 2023
@thepetk thepetk self-assigned this Dec 6, 2023
@thepetk thepetk moved this to Refinement in Devfile Project Dec 6, 2023
@michael-valdron
Copy link
Member

blocking community devfile registry promotion

@thepetk thepetk moved this from Refinement to In Review 👀 in Devfile Project Dec 7, 2023
@thepetk
Copy link
Contributor Author

thepetk commented Dec 7, 2023

Created devfile/registry#257 in order to address this issue

@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in Devfile Project Dec 13, 2023
@michael-valdron
Copy link
Member

Monitoring the results of the nightly testing, if there are problems I will re-open this issue.

@thepetk
Copy link
Contributor Author

thepetk commented Dec 15, 2023

I'm re-opening the issue as the nightly run still experiences issues (though I think they are not related)

cc @michael-valdron

@thepetk thepetk reopened this Dec 15, 2023
@thepetk thepetk moved this from Done ✅ to In Progress 🚧 in Devfile Project Dec 15, 2023
@thepetk
Copy link
Contributor Author

thepetk commented Dec 19, 2023

Closing this issue as I don't think is related to the nightly run failure

@thepetk thepetk closed this as completed Dec 19, 2023
@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✅ in Devfile Project Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/registry Devfile registry for stacks and infrastructure area/test-automation Test automation for devfile specification and library kind/bug Something isn't working
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

2 participants