Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple sample versions on Registry Viewer #1184

Closed
2 tasks
thepetk opened this issue Jul 11, 2023 · 3 comments
Closed
2 tasks

Support multiple sample versions on Registry Viewer #1184

thepetk opened this issue Jul 11, 2023 · 3 comments
Labels
area/documentation Improvements or additions to documentation area/registry-viewer kind/user-story User story for new enhancement lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days.

Comments

@thepetk
Copy link
Contributor

thepetk commented Jul 11, 2023

/kind user-story

Which area this user story is related to?

/area registry-viewer

User Story

As mentioned inside #1112 we would like to add reference to all samples to v2.2.0 parent stacks. To do so we will need to have multiple versions for samples like stacks (details in the description of referenced issue).

Right now the viewer is not supporting multiple versions on samples. More detailed as seen in the fetch-devfiles.tsx:

interface DevfileJsonSample extends DevfileJsonBase {
  type: 'sample';
  versions?: never;
}

interface DevfileJsonStack extends DevfileJsonBase {
  type: 'stack';
  versions: VersionDevfile[];
}

This also can be seen here on the viewer when fetching a sample, as there is no option to choose different versions of a sample:
Screenshot from 2023-07-11 12-06-43

Acceptance Criteria

  • Support multiple versions inside on the registry-viewer
  • Update any documentation referring to multiple versions of samples
@openshift-ci openshift-ci bot added the kind/user-story User story for new enhancement label Jul 11, 2023
@thepetk thepetk added area/documentation Improvements or additions to documentation area/registry-viewer labels Jul 11, 2023
@thepetk thepetk moved this to Need triage in Devfile Project Jul 11, 2023
@michael-valdron michael-valdron moved this to Backlog in Devfile Project Aug 2, 2023
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Oct 24, 2023
@michael-valdron michael-valdron moved this from Backlog to Refinement in Devfile Project Nov 28, 2023
@github-actions github-actions bot added the lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. label Dec 24, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 24, 2023
@github-project-automation github-project-automation bot moved this from Refinement to Done ✅ in Devfile Project Dec 24, 2023
@michael-valdron
Copy link
Member

This issue should be planned for an upcoming sprint once out of refinement.

@michael-valdron michael-valdron moved this from Done ✅ to Refinement in Devfile Project Jan 2, 2024
@michael-valdron michael-valdron removed lifecycle/stale Stale items. These items have not been updated for 90 days. lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. labels Jan 2, 2024
Copy link

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Sep 21, 2024
@github-actions github-actions bot added the lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. label Nov 21, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
@github-project-automation github-project-automation bot moved this from Refinement to Done ✅ in Devfile Project Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation area/registry-viewer kind/user-story User story for new enhancement lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days.
Projects
Status: Done ✅
Development

No branches or pull requests

3 participants