Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SchemaName on DefaultMigration overridable #1334

Open
remyblok opened this issue Oct 14, 2015 · 0 comments
Open

Make SchemaName on DefaultMigration overridable #1334

remyblok opened this issue Oct 14, 2015 · 0 comments

Comments

@remyblok
Copy link

We are using migration to add stuff to the database. We inherit our migrations from DefaultMigrator. This class has a property SchemaName. This property always contains a value stating with "bcms_". We want our tables in a schema prefix with our own product name, so that we can easily distinguish what is bcms and what is ours.
The SchemaName-property cannot be overridden so we are stuck with the "bcms_" prefix and so we do not use the SchemaName-property at the moment. It seems that BetterCMS also does not use the property for anything other then it Migrations. But in the future this might change for some reason. if then the SchemaName is incorrect it would lead to issues in our software.

Therefore I propose to make SchemaName in the DefaultMigrator-class virtual, so that we can override it and set the total schema name to something we want. Thanks!

@ghost ghost added the enhancement label Dec 22, 2015
@ghost ghost modified the milestone: Data Storage Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant