From f477329d7457eaa7d4983c883ae139f178118c4a Mon Sep 17 00:00:00 2001 From: Farhad Jay Date: Wed, 13 Nov 2024 13:54:13 -0800 Subject: [PATCH] Fix issue with expired events not being removed The event enter animation had a higher specificity than the remove animation, which meant the remove animation never took effect. Simply flipping the order of the two rulesets fixes the issue. --- assets/chat/css/chat/event-bar/_event-bar-event.scss | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/assets/chat/css/chat/event-bar/_event-bar-event.scss b/assets/chat/css/chat/event-bar/_event-bar-event.scss index e91babda..37bb53f2 100644 --- a/assets/chat/css/chat/event-bar/_event-bar-event.scss +++ b/assets/chat/css/chat/event-bar/_event-bar-event.scss @@ -102,13 +102,15 @@ transform: scale(1.05); } - &.removed { - animation: event-bar-disappear 500ms linear; - } - + // Ensure `removed` can override `enter` because `enter` is not removed from + // the event after the animation completes. &.enter { animation: event-bar-appear 500ms linear; } + + &.removed { + animation: event-bar-disappear 500ms linear; + } } @keyframes event-bar-appear {