Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity uses browser time, not server time to sign JWTs #43

Closed
Zyther opened this issue Jun 20, 2021 · 6 comments
Closed

Identity uses browser time, not server time to sign JWTs #43

Zyther opened this issue Jun 20, 2021 · 6 comments

Comments

@Zyther
Copy link

Zyther commented Jun 20, 2021

Steps to reproduce:

Use a Windows PC

  • Set local time on local PC one minute behind of actual time
  • get a token from identity.bitclout.com using a local browser
  • Token will already be expired
@maebeam
Copy link
Contributor

maebeam commented Jun 21, 2021

There's no way to fix this because Identity doesn't have a backend server to talk to and we don't want to add any server-side dependencies.

@maebeam maebeam closed this as completed Jun 21, 2021
@maebeam
Copy link
Contributor

maebeam commented Jun 21, 2021

I'm open to increasing the token expiry time or allowing the requester to specify an expiry time

@Zyther
Copy link
Author

Zyther commented Jun 24, 2021

Understood, and thank you.

@Zyther
Copy link
Author

Zyther commented Jun 24, 2021

After further thought, I feel this strictness is a good thing. Ensures all parties are in agreeance of the current time. Apologies!

@maebeam
Copy link
Contributor

maebeam commented Jun 24, 2021

I think we should increase the token expiry time to account for clock skew. 10-30 minutes seems reasonable

@maebeam
Copy link
Contributor

maebeam commented Jun 24, 2021

Increased to 10 minutes: d79b17c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants