Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send BitClout Approve Message is All Wrong #35

Closed
trevormil opened this issue Jun 3, 2021 · 2 comments
Closed

Send BitClout Approve Message is All Wrong #35

trevormil opened this issue Jun 3, 2021 · 2 comments

Comments

@trevormil
Copy link
Contributor

Issue: Approve message for window.open("https://identity.bitclout.com/approve?tx=abc123....") is all wrong for basic transactions of sending bitclout.

At the file identity/src/app/approve/approve.component.ts in generateTransactionDescription(), when the case is a TransactionMetadataBasicTransfer, the display message is all wrong.

  1. It shows total amount of nanos in the transaction including ChangeAmountNanos which is misleading. It should only be SpendAmountNanos.
  2. The public key displayed is the sender's whereas it should be the recipients

When I use the /v0/send-bitclout api route to send 0.1 bitclout worth in nanos from BC1YLiXsLZvrySthVJPJozLr3rMSo2BARZ4VG525bhbsAJCTvwJQJCe to BC1YLh4R1ewSLphyWncnUsRmJ5okAn4xjRMUHD5Q6vVd5ZAYgf8zWZo, I get the following message:

localhost wants to send 0.203897603 bitclout to BC1YLiXsLZvrySthVJPJozLr3rMSo2BARZ4VG525bhbsAJCTvwJQJCe

@maebeam
Copy link
Contributor

maebeam commented Jun 3, 2021

Thanks for raising this issue! We will prioritize a fix.

@maebeam
Copy link
Contributor

maebeam commented Jun 6, 2021

Fixed!

@maebeam maebeam closed this as completed Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants