Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specsim desimodel dependency #138

Open
weaverba137 opened this issue May 17, 2024 · 3 comments
Open

specsim desimodel dependency #138

weaverba137 opened this issue May 17, 2024 · 3 comments
Labels

Comments

@weaverba137
Copy link
Member

I'm not sure where this was introduced, but a dependency on desimodel has been introduced into specsim, which means that specsim is no longer independent of the DESI software stack. Furthermore, desimodel required desiutil, so that's two DESI packages.

In contrast, speclite is still independent of the DESI software stack.

What is the long-term intention for specsim maintenance in this regard?

@dkirkby
Copy link
Member

dkirkby commented May 17, 2024

My intent is that there are no python import dependencies on any DESI packages.

The only (soft) dependency should be that the desi.yaml file refers to paths within $DESIMODEL.

@weaverba137
Copy link
Member Author

OK, but that's not what I see in the code. Both specsim.instrument and specsim.fastfiberacceptance import desimodel.fastfiberacceptance. I do see other references to $DESIMODEL which is probably OK, but those import statements definitely create a dependency.

@dkirkby
Copy link
Member

dkirkby commented May 17, 2024

That came from #114 from @julienguy but I don't remember why this was needed. Hopefully he can comment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants