Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZLYA VAC Review (DR1) #11

Open
3 of 4 tasks
dylanagreen opened this issue Dec 7, 2023 · 2 comments
Open
3 of 4 tasks

ZLYA VAC Review (DR1) #11

dylanagreen opened this issue Dec 7, 2023 · 2 comments
Assignees

Comments

@dylanagreen
Copy link

Draft directory:/global/cfs/cdirs/desi/users/abrodze/QSOredshiftsY1/zlya-QSO-DR1-v0
1 catalog file, 3 files total

Initial Checks:

  • Includes README
  • Columns in ALLCAPS
  • Extension names in ALLCAPS
  • Files include units

Initial Notes:

  • Can you draft a short (~1-2 paragraph) summary of the VAC to include in the DR1 paper? For an example of what this would look like you can look at section 3.3.6 of the EDR paper (https://arxiv.org/abs/2306.06308).
  • It looks like you have an .ipynb_checkpoints folder in your VAC directory, unless we need it I think we should delete it
  • If possible can you propagate the degree units to the catalog (as outlined in the README)?
  • No comments on the README at this time except to include paper links when they're available, although in the near future it'll need to be reformatted to match desidatadocs.
@dylanagreen dylanagreen self-assigned this Dec 7, 2023
@abrodze
Copy link
Member

abrodze commented Dec 11, 2023

Thanks for the review. The checkpoint file has been deleted and units are added. Text for the DR1 paper will be emailed.

@abrodze
Copy link
Member

abrodze commented Mar 8, 2024

updated version directory: /global/cfs/cdirs/desi/users/abrodze/quasarsY1/Y1-catalogs/VACs/zlya-QSO-DR1-v1

edit (4/16): v2 adds an additional column: /global/cfs/cdirs/desi/users/abrodze/quasarsY1/Y1-catalogs/VACs/zlya-QSO-DR1-v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants