Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc feedback on new version. #57

Closed
Carreau opened this issue Aug 26, 2021 · 2 comments
Closed

Misc feedback on new version. #57

Carreau opened this issue Aug 26, 2021 · 2 comments

Comments

@Carreau
Copy link
Contributor

Carreau commented Aug 26, 2021

Thanks @echarles for pushing this forward, I've tried the new version and it was relatively straightforward.

A couple of notes:

  1. we might want some instructions on how to create a template in the readme
    • or maybe even directly in the launcher.
    • or even a way to create one from a form I dont' know.
  2. I like the pipette to mean pick new parameters.
  3. I'm not sure what "Launch" is the right name. Maybe "create kernelspec" or something else.
  4. uncaught error if one submit the forms without filling all the values.
  5. deleting a kernelspec still uses "alert".
@echarles
Copy link
Contributor

echarles commented Aug 27, 2021

Thx a lot @Carreau for reviewing. Very useful feedback it helps a lot.

we might want some instructions on how to create a template in the readme

PR on its way

or maybe even directly in the launcher.

PR on its way

or even a way to create one from a form I dont' know.

#59

I like the pipette to mean pick new parameters.

:)

I'm not sure what "Launch" is the right name. Maybe "create kernelspec" or something else.

Fixed in #60

uncaught error if one submit the forms without filling all the values.

#61

deleting a kernelspec still uses "alert".

#62

@echarles
Copy link
Contributor

we might want some instructions on how to create a template in the readme
PR on its way
or maybe even directly in the launcher.
PR on its way

Implemented in #63

Closing as all commented have been implemented or recorded in separated issues.

Looking forward more feedbacks in the future.

@ericdatakelly ericdatakelly added this to the August 2021 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants