Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obj is not iterable #308

Open
Craigy- opened this issue Oct 19, 2022 · 2 comments
Open

obj is not iterable #308

Craigy- opened this issue Oct 19, 2022 · 2 comments

Comments

@Craigy-
Copy link

Craigy- commented Oct 19, 2022

After updating this script from 4.1.0 to 5.0.0 without any changes of initialization code, it's now thrown error and doesn't work:

Uncaught TypeError: obj is not iterable

Initialization code:

$('.js-b').each(function () {
    console.log($(this));
    $(this).imagesLoaded().done(function () {
      ...
    });
});

console.log => Object { 0: div.all-b.vertical-b.js-b, context: div.all-b.vertical-b.js-b, length: 1 }

@dan-bizango
Copy link

@Craigy-
I was having the same issue.

I made a simple test with the jquery version of images loaded with a simple container loading a number of images as immediate children and was still getting the 'obj not iterable' error.

I just went in and updated the code in the in the script to use the Object.values() method to convert to an array so that I didn't run into the iterable issue with the Object.

I updated this
if (isArrayLike) return [...obj];
To this
if (isArrayLike) return Object.values(obj);

And all is working now,

@r-anwar
Copy link

r-anwar commented Jan 7, 2024

The issue also occurs on WordPress 6.4.2.

The following combination is running there:

  • imagesloaded 5.0.0
  • masonry 4.2.2

After modifying line 138 in the imagesloaded script, the script runs without errors:

Line 138:

if ( isArrayLike ) return [ ...obj ];

Changed to:

if (isArrayLike) return Object.values(obj);

Please take a close look at the issue and fix it. All WP pages currently upgrading and using imagesloaded with masonry will encounter this problem. Furthermore, the current fix is not persistent, as the file will be overwritten with the original during the next upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants