Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False-positive on Angular aria-label binding #53

Open
JeffreyNordlieTR opened this issue Nov 13, 2024 · 3 comments
Open

False-positive on Angular aria-label binding #53

JeffreyNordlieTR opened this issue Nov 13, 2024 · 3 comments
Assignees

Comments

@JeffreyNordlieTR
Copy link

It appears to not be detecting that the button has an aria-label:
Image

@WilcoFiers
Copy link

@JeffreyNordlieTR thank you for raising this. Yeah that should definitely pass. Surprising.

@zlayaAvocado
Copy link

zlayaAvocado commented Nov 19, 2024

It appears to not be detecting that the button has an aria-label: Image

It looks like the Angular component html file is named -component.html instead of .component.html. Do you have any linting overrides set up in the axe-linter.yml? E.g. something like:

overrides:
  - files: "*.html"
    linter: angular

If yes, it seems like it doesn't currently work as expected and would still show a linting error, and we are investigating why. If the project allows, as a temporary workaround you can rename the component file to .component.html and linting should work correctly.

@zlayaAvocado
Copy link

@JeffreyNordlieTR Just an update! We found an issue with the files overrides not working if the file value is a string, however, the array should still work if you would like to set up an override:

overrides:
  - files: 
    - "**/*.html"
    linter: angular

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants