From 52a3eb57fb9804917c603fe0112c6a6fb164918d Mon Sep 17 00:00:00 2001 From: Jun Tao Luo Date: Fri, 27 Dec 2024 12:08:24 -0500 Subject: [PATCH] Update DS review page --- .../vaos/covid-19-vaccine/components/ReviewPage.jsx | 2 +- .../components/ReviewPage.unit.spec.js | 4 +++- src/applications/vaos/covid-19-vaccine/flow.js | 6 +++--- .../components/ReviewPage/index.direct.unit.spec.js | 4 +++- .../vaos/new-appointment/newAppointmentFlow.js | 4 ++-- src/applications/vaos/services/mocks/v2/slots.json | 8 ++++++++ .../ophthalmology.cypress.spec.js | 2 +- .../primary-care.cypress.spec.js | 12 ++++++------ 8 files changed, 27 insertions(+), 15 deletions(-) diff --git a/src/applications/vaos/covid-19-vaccine/components/ReviewPage.jsx b/src/applications/vaos/covid-19-vaccine/components/ReviewPage.jsx index 902dac7f0960..9b9565033661 100644 --- a/src/applications/vaos/covid-19-vaccine/components/ReviewPage.jsx +++ b/src/applications/vaos/covid-19-vaccine/components/ReviewPage.jsx @@ -17,7 +17,7 @@ import { confirmAppointment } from '../redux/actions'; import AppointmentDate from '../../new-appointment/components/ReviewPage/AppointmentDate'; import { selectFeatureBreadcrumbUrlUpdate } from '../../redux/selectors'; -const pageTitle = 'Review your appointment details'; +const pageTitle = 'Review and confirm your appointment details'; function handleClick(history, contactInfo) { return e => { diff --git a/src/applications/vaos/covid-19-vaccine/components/ReviewPage.unit.spec.js b/src/applications/vaos/covid-19-vaccine/components/ReviewPage.unit.spec.js index 42aabc7c199b..475d1ba76287 100644 --- a/src/applications/vaos/covid-19-vaccine/components/ReviewPage.unit.spec.js +++ b/src/applications/vaos/covid-19-vaccine/components/ReviewPage.unit.spec.js @@ -139,7 +139,9 @@ describe('VAOS vaccine flow: ReviewPage', () => { dateHeading, facilityHeading, ] = screen.getAllByRole('heading'); - expect(pageHeading).to.contain.text('Review your appointment details'); + expect(pageHeading).to.contain.text( + 'Review and confirm your appointment details', + ); expect(descHeading).to.contain.text('COVID-19 vaccine'); expect(descHeading).to.have.tagName('h2'); diff --git a/src/applications/vaos/covid-19-vaccine/flow.js b/src/applications/vaos/covid-19-vaccine/flow.js index 6fb7f36cbd1e..20e26dc9b760 100644 --- a/src/applications/vaos/covid-19-vaccine/flow.js +++ b/src/applications/vaos/covid-19-vaccine/flow.js @@ -61,7 +61,7 @@ export default function getPageFlow(state) { url: featureBreadcrumbUrlUpdate ? 'review' : '/new-covid-19-vaccine-appointment/review', - label: 'Review your appointment details', + label: 'Review and confirm your appointment details', next: '', }, root: { @@ -147,11 +147,11 @@ export function routeToNextAppointmentPage(history, current, data) { } /* Function to get label from the flow - * The URL displayed in the browser address bar is compared to the + * The URL displayed in the browser address bar is compared to the * flow URL * * @export - * @param {object} state + * @param {object} state * @param {string} location - the pathname * @returns {string} the label string */ diff --git a/src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js b/src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js index b41b2fb48caf..38e329b7a1ce 100644 --- a/src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js +++ b/src/applications/vaos/new-appointment/components/ReviewPage/index.direct.unit.spec.js @@ -127,7 +127,9 @@ describe('VAOS Page: ReviewPage direct scheduling with v2 api', () => { reasonHeading, contactHeading, ] = screen.getAllByRole('heading'); - expect(pageHeading).to.contain.text('Review your appointment details'); + expect(pageHeading).to.contain.text( + 'Review and confirm your appointment details', + ); expect(descHeading).to.contain.text( 'scheduling a primary care appointment', ); diff --git a/src/applications/vaos/new-appointment/newAppointmentFlow.js b/src/applications/vaos/new-appointment/newAppointmentFlow.js index 0ed089541a73..ff7546089f95 100644 --- a/src/applications/vaos/new-appointment/newAppointmentFlow.js +++ b/src/applications/vaos/new-appointment/newAppointmentFlow.js @@ -317,7 +317,7 @@ const flow = { }, review: { url: '/new-appointment/review', - label: 'Review your appointment details', + label: 'Review and confirm your appointment details', }, }; @@ -416,7 +416,7 @@ export default function getNewAppointmentFlow(state) { ...flow.review, label: FLOW_TYPES.DIRECT === flowType - ? 'Review your appointment details' + ? 'Review and confirm your appointment details' : 'Review and submit your request', url: featureBreadcrumbUrlUpdate ? 'review' : '/new-appointment/review', }, diff --git a/src/applications/vaos/services/mocks/v2/slots.json b/src/applications/vaos/services/mocks/v2/slots.json index 53953514e5c5..e6a31888eb2e 100644 --- a/src/applications/vaos/services/mocks/v2/slots.json +++ b/src/applications/vaos/services/mocks/v2/slots.json @@ -2487,6 +2487,14 @@ "start": "2024-08-22T21:15:00Z", "end": "2024-08-22T00:00:00Z" } + }, + { + "id": "1913", + "type": "slots", + "attributes": { + "start": "2025-08-22T21:15:00Z", + "end": "2025-08-22T00:00:00Z" + } } ] } \ No newline at end of file diff --git a/src/applications/vaos/tests/e2e/workflows/direct-schedule-workflow/ophthalmology.cypress.spec.js b/src/applications/vaos/tests/e2e/workflows/direct-schedule-workflow/ophthalmology.cypress.spec.js index 41fe0e10b870..9541fd51f28f 100644 --- a/src/applications/vaos/tests/e2e/workflows/direct-schedule-workflow/ophthalmology.cypress.spec.js +++ b/src/applications/vaos/tests/e2e/workflows/direct-schedule-workflow/ophthalmology.cypress.spec.js @@ -143,7 +143,7 @@ describe('VAOS request schedule flow - Audiology', () => { ReviewPageObject.assertUrl() .assertHeading({ - name: /Review your appointment details/i, + name: /Review and confirm your appointment details/i, }) .assertHeading({ level: 2, diff --git a/src/applications/vaos/tests/e2e/workflows/direct-schedule-workflow/primary-care.cypress.spec.js b/src/applications/vaos/tests/e2e/workflows/direct-schedule-workflow/primary-care.cypress.spec.js index 4955a341b9d1..c1e41de67dcc 100644 --- a/src/applications/vaos/tests/e2e/workflows/direct-schedule-workflow/primary-care.cypress.spec.js +++ b/src/applications/vaos/tests/e2e/workflows/direct-schedule-workflow/primary-care.cypress.spec.js @@ -137,7 +137,7 @@ describe('VAOS direct schedule flow - Primary care', () => { ReviewPageObject.assertUrl() .assertHeading({ - name: /Review your appointment details/i, + name: /Review and confirm your appointment details/i, }) .assertHeading({ level: 2, @@ -209,7 +209,7 @@ describe('VAOS direct schedule flow - Primary care', () => { ReviewPageObject.assertUrl() .assertHeading({ - name: /Review your appointment details/i, + name: /Review and confirm your appointment details/i, }) .assertHeading({ level: 2, @@ -291,7 +291,7 @@ describe('VAOS direct schedule flow - Primary care', () => { ReviewPageObject.assertUrl() .assertHeading({ - name: /Review your appointment details/i, + name: /Review and confirm your appointment details/i, }) .assertHeading({ level: 2, @@ -481,7 +481,7 @@ describe('VAOS direct schedule flow - Primary care', () => { ReviewPageObject.assertUrl() .assertHeading({ - name: /Review your appointment details/i, + name: /Review and confirm your appointment details/i, }) .assertHeading({ level: 2, @@ -548,7 +548,7 @@ describe('VAOS direct schedule flow - Primary care', () => { ReviewPageObject.assertUrl() .assertHeading({ - name: /Review your appointment details/i, + name: /Review and confirm your appointment details/i, }) .assertHeading({ level: 2, @@ -711,7 +711,7 @@ describe('VAOS direct schedule flow - Primary care', () => { ReviewPageObject.assertUrl() .assertHeading({ - name: /Review your appointment details/i, + name: /Review and confirm your appointment details/i, }) .assertHeading({ level: 2,