From c2b24c28185205ffb23fb496f642d8f1e5225413 Mon Sep 17 00:00:00 2001
From: Joshua Drumm <34111449+JoshingYou1@users.noreply.github.com>
Date: Wed, 29 Nov 2023 11:19:13 -0500
Subject: [PATCH] Refactored 'associations' to 'veteranContacts' for less
 ambiguity (#821)

---
 dist/10-10EZR-schema.json      |  2 +-
 dist/definitions.json          |  2 +-
 package.json                   |  2 +-
 src/common/definitions.js      | 16 ++++++++--------
 src/schemas/10-10EZR/schema.js |  2 +-
 5 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/dist/10-10EZR-schema.json b/dist/10-10EZR-schema.json
index 6daebdc2d..c9cfaa718 100644
--- a/dist/10-10EZR-schema.json
+++ b/dist/10-10EZR-schema.json
@@ -970,7 +970,7 @@
         true
       ]
     },
-    "associations": {
+    "veteranContacts": {
       "type": "array",
       "items": {
         "type": "object",
diff --git a/dist/definitions.json b/dist/definitions.json
index 010131f93..254701109 100644
--- a/dist/definitions.json
+++ b/dist/definitions.json
@@ -1297,7 +1297,7 @@
       "step"
     ]
   },
-  "associations": {
+  "hcaVeteranContacts": {
     "type": "array",
     "items": {
       "type": "object",
diff --git a/package.json b/package.json
index fae2336cb..3eef1aa53 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "vets-json-schema",
-  "version": "20.32.4",
+  "version": "20.33.4",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/department-of-veterans-affairs/vets-json-schema.git"
diff --git a/src/common/definitions.js b/src/common/definitions.js
index af065631e..5d1319c9a 100644
--- a/src/common/definitions.js
+++ b/src/common/definitions.js
@@ -366,7 +366,7 @@ const hcaDependents = {
   },
 };
 
-const associationRelationships = {
+const hcaVeteranContactRelationships = {
   type: 'string',
   enum: [
     'BROTHER',
@@ -387,27 +387,27 @@ const associationRelationships = {
   ],
 };
 
-const associationTypes = {
+const hcaVeteranContactTypes = {
   type: 'string',
   enum: ['Primary Next of Kin', 'Other Next of Kin', 'Emergency Contact', 'Other emergency contact'],
 };
 
-const association = {
+const hcaVeteranContact = {
   type: 'object',
   properties: {
     fullName: hcaFullName,
     primaryPhone: hcaPhone,
     alternatePhone: hcaPhone,
     address: hcaAddress,
-    relationship: associationRelationships,
-    contactType: associationTypes,
+    relationship: hcaVeteranContactRelationships,
+    contactType: hcaVeteranContactTypes,
   },
   required: ['fullName', 'primaryPhone', 'address', 'relationship', 'contactType'],
 };
 
-const associations = {
+const hcaVeteranContacts = {
   type: 'array',
-  items: association,
+  items: hcaVeteranContact,
 };
 
 // Historically a veteran's service number has been between 5 and 8 digits,
@@ -942,7 +942,7 @@ export default {
   netWorthAccount,
   relationshipAndChildName,
   relationshipAndChildType,
-  associations,
+  hcaVeteranContacts,
   marriages,
   files,
   requiredServiceHistory,
diff --git a/src/schemas/10-10EZR/schema.js b/src/schemas/10-10EZR/schema.js
index dbeb12780..a7865db66 100644
--- a/src/schemas/10-10EZR/schema.js
+++ b/src/schemas/10-10EZR/schema.js
@@ -75,7 +75,7 @@ const schema = {
       type: 'boolean',
       enum: [true],
     },
-    associations: definitions.associations,
+    veteranContacts: definitions.hcaVeteranContacts,
   },
   required: [
     'privacyAgreementAccepted',