Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va-file-input: Show a previously-uploaded file #3634

Open
4 tasks
caw310 opened this issue Dec 17, 2024 · 5 comments
Open
4 tasks

va-file-input: Show a previously-uploaded file #3634

caw310 opened this issue Dec 17, 2024 · 5 comments
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team va-file-input

Comments

@caw310
Copy link
Contributor

caw310 commented Dec 17, 2024

Description

Update the va-file input component to include a way to show that a file has been uploaded that doesn't require the file itself.

Details

Slack discussion: https://dsva.slack.com/archives/C085JHZMQ67

Tasks

  • Update va-file-input to show a previously-uploaded file
  • Test that this is working
  • Push to prod

Acceptance Criteria

  • va-file-input can show a previously-uploaded file without access to the file itself
@caw310 caw310 added platform-design-system-team va-file-input DST-engineering Issues that require work from Design System Team engineers labels Dec 17, 2024
@Thrillberg
Copy link

Can we fold into this ticket the behavior shown in this screenshot? Specifically we're looking for an ability to show "Uploading..." while the file is uploading. I've looked around here: https://design.va.gov/storybook/?path=/docs/uswds-va-file-input--docs and not found anything that looks quite like what we're looking for. I figured perhaps in addition to name and size we could provide an uploading boolean that would trigger some sort of Uploading... state (like shown in the screenshot here).

Image

@caw310
Copy link
Contributor Author

caw310 commented Jan 6, 2025

Provide your estimate of 1, 2, 3, 5, 8 or 13
@Andrew565 - 3
@ataker -
@harshil1793 - 5
@it-harrison -
@jamigibbs -
@micahchiang -
@powellkerry - 5
@rmessina1010 -
@rsmithadhoc - 3

@Andrew565
Copy link
Contributor

Specifically we're looking for an ability to show "Uploading..." while the file is uploading.

@Thrillberg This is not a bad idea, but it's out of scope for this ticket. Please submit a separate request.

@Thrillberg
Copy link

@Thrillberg This is not a bad idea, but it's out of scope for this ticket. Please submit a separate request.

Sure thing! Here is another issue: #3660

@Andrew565
Copy link
Contributor

Related Slack convo here.

Ultimate goal of this ticket is to provide a way to show that a file has previously been uploaded, without requiring the file itself. The "name" and "size" props were suggested as a way to 'fill in the blanks' because those values are what are currently available to the developer from the Redux store.

Another option would be to override the existing "value" prop to accept an object (e.g. {name: "File Name", size: "XXkb"}) in addition to a File.

@Andrew565 Andrew565 changed the title Update va-file-input component props va-file-input: Show a previously-uploaded file Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team va-file-input
Projects
None yet
Development

No branches or pull requests

3 participants