Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] Determine button line height #2984

Closed
13 tasks
babsdenney opened this issue Jul 1, 2024 · 5 comments
Closed
13 tasks

[Design] Determine button line height #2984

babsdenney opened this issue Jul 1, 2024 · 5 comments

Comments

@babsdenney
Copy link
Contributor

babsdenney commented Jul 1, 2024

Description

You can read the background about this ticket in the development ticket below.

Update button line height #2963

We need to determine a new line height for buttons so that the button text doesn't run together. Once a new line-height is determined, update Figma and dev ticket with the new line height.

Details

Button in Figma
Button in Storybook

Tasks

  • Determine the button line height
  • Review with DST Designers, PO, and PM
  • Review designs with developers and accessibility specialist
  • Update all Figma components with the new line height
  • Update this ticket with the line height needed to be implemented in code
  • Address any comments from reviews, if necessary
  • Comment on this ticket with any accessibility considerations engineers may need to know
  • Comment on this ticket with content specifications (e.g. labels and error messages)
  • Comment on this ticket with a link to the designs and post in DST Slack channel

Acceptance Criteria

  • Component design is complete and has been reviewed
  • Accessibility and development considerations have been added to this ticket, if necessary
  • Content specifications have been added to this ticket, if necessary
  • Link to design has been added to this ticket and shared in Slack
@caw310
Copy link
Contributor

caw310 commented Jul 2, 2024

Hey team! Please add your planning poker estimate with Zenhub @babsdenney @danbrady @LWWright7

@LWWright7
Copy link
Contributor

@danbrady @babsdenney - This is ready for review. I used the USWDS spacing for guidance and created examples to show what the button would look like with spacing at the USWDS breakpoints (1, 1.15, 1.35, 1.5, 1.62, 1.75 and I added 2 just for funzies).

@danbrady
Copy link
Contributor

Really great work, @LWWright7! I like how you laid out the options and used USWDS as a guide.

@LWWright7
Copy link
Contributor

This ticket is blocked by a research ticket for dev: 3088

@LWWright7
Copy link
Contributor

Closing this ticket as the line height has been determined through research into USWDS breakpoints in this ticket:

Screen Shot 2024-07-25 at 10 32 27 AM

I've created a new ticket to actually update Figma component depending on the research that the dev team does in this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants