Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap css import in the injected header style-consolidated stylesheet #2979

Closed
1 task
micahchiang opened this issue Jun 27, 2024 · 2 comments
Closed
1 task
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team

Comments

@micahchiang
Copy link
Contributor

Description

We recently discovered that the global stylesheet for our web components is being imported into style-consolidated.scss, but the only thing that's really needed is css variables from css-library. This import should be updated to directly import our css-library variables instead.

Tasks

  • Change this import: @import '~@department-of-veterans-affairs/component-library/dist/main.css'; to @import '~@department-of-veterans-affairs/css-library/dist/tokens/scss/variables.scss';
  • verify the injected header continues to work by running the proxy-rewrite application locally

Acceptance Criteria

  • Above tasks have been completed
@micahchiang micahchiang added DST-engineering Issues that require work from Design System Team engineers platform-design-system-team labels Jun 27, 2024
@caw310
Copy link
Contributor

caw310 commented Jul 2, 2024

@micahchiang
Copy link
Contributor Author

Closing this because it's no longer needed. Randi's recent work to decouple the injected header removed the need for this import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team
Projects
None yet
Development

No branches or pull requests

2 participants