Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Library - Refactor app by app imports #2976

Open
2 tasks
micahchiang opened this issue Jun 27, 2024 · 0 comments
Open
2 tasks

CSS Library - Refactor app by app imports #2976

micahchiang opened this issue Jun 27, 2024 · 0 comments

Comments

@micahchiang
Copy link
Contributor

Description

Many applications in vets-website import the same handful of sass modules directly into their application structure:

@import "~@department-of-veterans-affairs/formation/sass/shared-variables";
@import "~@department-of-veterans-affairs/formation/sass/modules/m-process-list";
@import "~@department-of-veterans-affairs/formation/sass/modules/m-form-process";
@import "../../../platform/forms/sass/m-schemaform";
@import "~@department-of-veterans-affairs/formation/sass/modules/m-modal";
@import "~@department-of-veterans-affairs/formation/sass/modules/m-omb-info";
@import "../../../platform/forms/sass/m-form-confirmation";

Note: by the time we prioritize this ticket, the import paths above will likely point to css-library

We need to spend some time determining whether or not all of these can be refactored and rely on the platform provided imports instead.

Tasks

  • Pick an app in vets-website and attempt to remove the sass imports, see what breaks, determine if there's a good way for that app to inherit from platform so we can reduce the amount of redundancy in vets-website
  • Compile findings into a doc or comment on this ticket that will help us determine whether or not we can move forward with a broader refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant