Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va-official-gov-banner padding issue #2097

Closed
6 tasks
ataker opened this issue Sep 15, 2023 · 1 comment · Fixed by department-of-veterans-affairs/component-library#973
Closed
6 tasks

va-official-gov-banner padding issue #2097

ataker opened this issue Sep 15, 2023 · 1 comment · Fixed by department-of-veterans-affairs/component-library#973
Assignees
Labels
bug Something isn't working DST-engineering Issues that require work from Design System Team engineers platform-design-system-team

Comments

@ataker
Copy link
Contributor

ataker commented Sep 15, 2023

Bug Report

  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

va-official-gov-banner padding issue at medium size. "Here's how you know" text is wrapping to a new line incorrectly

268127331-b21bb235-e6c7-48f7-a766-5b07de71e0a2

What I expected to happen

There are three outcomes that I think would be acceptable:

  1. It wraps to the new line without issue
  2. It stay on the same line as "Official website..." text as it appears to be enough room at this size
  3. It converts to the smaller version seen on va.gov:
    Screenshot 2023-09-15 at 15 15 54

Reproducing

  • Formation version:
  • Device: (e.g. iPhone 8, Macbook)
  • Browser: (e.g. Firefox, IE 11)

Urgency

How urgent is this request? Please select the approriate option below and/or provide details

  • This bug is blocking work currently in progress
  • This bug is affecting work currently in progress but we have a workaround
  • This bug is blocking work planned within the next few sprints
  • This bug is not blocking any work
  • Other

Details

First reported on the va-minimal-header PR

@ataker ataker added bug Something isn't working platform-design-system-team labels Sep 15, 2023
@caw310 caw310 added the DST-engineering Issues that require work from Design System Team engineers label Sep 18, 2023
@caw310
Copy link
Contributor

caw310 commented Oct 5, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DST-engineering Issues that require work from Design System Team engineers platform-design-system-team
Projects
None yet
3 participants