Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

97625 Debt Team FSR missing housing expenses #19656

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

digitaldrk
Copy link
Contributor

@digitaldrk digitaldrk commented Nov 27, 2024

Summary

  • This work is behind a feature toggle (flipper): YES/NO: No
  • (Summarize the changes that have been made to the platform): We have a bug where expected parameters are not getting sent into vets-api due to them not being listed in strong parameters
  • (If bug, how to reproduce): We've been submitting forms via vets-website. We confirmed that the values are populating as intended now.
  • (What is the solution, why is this the solution?): Params needed to be accepted to move them along to our services.
  • (Which team do you work for, does your team own the maintenance of this component?): debt-resolution. You can find me on the Octo slack at #debt-resolution. We own this code.
  • (If introducing a flipper, what is the success criteria being targeted?): N/A

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@digitaldrk digitaldrk marked this pull request as ready for review November 27, 2024 22:39
@digitaldrk digitaldrk requested review from a team as code owners November 27, 2024 22:39
@va-vfs-bot va-vfs-bot temporarily deployed to 97625_debt_team_FSR_missing_housing_expenses/main/main November 27, 2024 22:42 Inactive
Copy link
Contributor

@amponce amponce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, lgtm! That's interesting that you encapsulate both of those properties in an object like that!

Copy link

Backend-review-group approval confirmed.

@digitaldrk digitaldrk merged commit 323159a into master Nov 29, 2024
30 of 31 checks passed
@digitaldrk digitaldrk deleted the 97625_debt_team_FSR_missing_housing_expenses branch November 29, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants