Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE | Ask Va Api: Add test_create endpoint #16391

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

Khoa-V-Nguyen
Copy link
Contributor

Summary

  • Created test_create endpoint to test post to CRM API

Related issue(s)

  • Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira
  • Link to previous change of the code/bug (if applicable)
  • Link to epic if not included in ticket

Testing done

  • New code is covered by unit tests

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

@Khoa-V-Nguyen Khoa-V-Nguyen self-assigned this Apr 17, 2024
@Khoa-V-Nguyen Khoa-V-Nguyen requested review from a team as code owners April 17, 2024 20:20
@Khoa-V-Nguyen Khoa-V-Nguyen force-pushed the ask-va-api-post-test-endpdoint branch from 23c5e7d to ce0dc40 Compare April 17, 2024 20:22
@Khoa-V-Nguyen Khoa-V-Nguyen enabled auto-merge (squash) April 17, 2024 20:23
@Khoa-V-Nguyen Khoa-V-Nguyen force-pushed the ask-va-api-post-test-endpdoint branch from ce0dc40 to fd8351a Compare April 17, 2024 20:26
Copy link
Contributor

@joehall-tw joehall-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Khoa-V-Nguyen Khoa-V-Nguyen force-pushed the ask-va-api-post-test-endpdoint branch from fd8351a to 7310e89 Compare April 17, 2024 20:49
@Khoa-V-Nguyen Khoa-V-Nguyen merged commit 4d200de into master Apr 17, 2024
20 checks passed
@Khoa-V-Nguyen Khoa-V-Nguyen deleted the ask-va-api-post-test-endpdoint branch April 17, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants