From 2f59875579bb17b1890103a3b53eb108172fd1df Mon Sep 17 00:00:00 2001 From: Dewayne VanHoozer Date: Thu, 25 Apr 2024 09:07:19 -0500 Subject: [PATCH 1/2] changed variable name api_statsD_key to api_statsd_key because the linter says all letters should be lowercase. --- app/sidekiq/central_mail/submit_form4142_job.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/sidekiq/central_mail/submit_form4142_job.rb b/app/sidekiq/central_mail/submit_form4142_job.rb index 2c1b20386f7..19e0e7e6f84 100644 --- a/app/sidekiq/central_mail/submit_form4142_job.rb +++ b/app/sidekiq/central_mail/submit_form4142_job.rb @@ -52,13 +52,13 @@ class VeteranCountryNotDefined < StandardError; end bgjob_errors: bgjob_errors.merge(new_error) ) - api_statsD_key = if Flipper.enabled?(:disability_compensation_form_4142) + api_statsd_key = if Flipper.enabled?(:disability_compensation_form_4142) LIGHTHOUSE_STATSD_KEY_PREFIX else CENTRAL_MAIL_STATSD_KEY_PREFIX end - StatsD.increment("#{api_statsD_key}.exhausted") + StatsD.increment("#{api_statsd_key}.exhausted") ::Rails.logger.warn( 'Submit Form 4142 Retries exhausted', From b2412aa1f38c3e6b7c376ed6145804b6ceb04f48 Mon Sep 17 00:00:00 2001 From: Dewayne VanHoozer Date: Thu, 25 Apr 2024 09:16:21 -0500 Subject: [PATCH 2/2] put new flipper feature into proper alphabetic order within file --- config/features.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/config/features.yml b/config/features.yml index dad3ea67217..4eba904eba3 100644 --- a/config/features.yml +++ b/config/features.yml @@ -372,6 +372,10 @@ features: actor_type: user description: enables sending flashes to BGS for disability_compensation submissions. enable_in_development: true + disability_compensation_form_4142: + actor_type: user + description: Use Lighthouse API to submit supplemental Form 21-4142 from Form 526EZ submissions + enable_in_development: true disability_compensation_pif_fail_notification: actor_type: user description: enables sending notifications to vets if their 526 claim submission fails with PIF in Use Error @@ -1031,10 +1035,6 @@ features: actor_type: user description: Form 526 subforms for unemployability & connected employment information enable_in_development: true - disability_compensation_form_4142: - actor_type: user - description: Use Lighthouse API to submit supplemental Form 21-4142 from Form 526EZ submissions - enable_in_development: true va_online_scheduling: actor_type: user description: Allows veterans to view their VA and Community Care appointments