From e9fdb20c08370eaf17b3c1d3786071971d01fcc8 Mon Sep 17 00:00:00 2001 From: Casey Williams Date: Mon, 22 Apr 2024 10:28:34 -0700 Subject: [PATCH] API-34961 Rename appeals PII jobs (#16420) --- lib/periodic_jobs.rb | 10 +++++----- ..._old_pii.rb => higher_level_review_clean_up_pii.rb} | 2 +- ...d_pii.rb => notice_of_disagreement_clean_up_pii.rb} | 2 +- ...pec.rb => higher_level_review_clean_up_pii_spec.rb} | 2 +- ....rb => notice_of_disagreement_clean_up_pii_spec.rb} | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) rename modules/appeals_api/app/sidekiq/appeals_api/{higher_level_review_clean_up_week_old_pii.rb => higher_level_review_clean_up_pii.rb} (91%) rename modules/appeals_api/app/sidekiq/appeals_api/{notice_of_disagreement_clean_up_week_old_pii.rb => notice_of_disagreement_clean_up_pii.rb} (90%) rename modules/appeals_api/spec/sidekiq/{higher_level_review_clean_up_week_old_pii_spec.rb => higher_level_review_clean_up_pii_spec.rb} (92%) rename modules/appeals_api/spec/sidekiq/{notice_of_disagreement_clean_up_week_old_pii_spec.rb => notice_of_disagreement_clean_up_pii_spec.rb} (91%) diff --git a/lib/periodic_jobs.rb b/lib/periodic_jobs.rb index f56bef279c0..2af35e74c3a 100644 --- a/lib/periodic_jobs.rb +++ b/lib/periodic_jobs.rb @@ -14,12 +14,12 @@ # Update NoticeOfDisagreement statuses with their Central Mail status mgr.register('15 * * * *', 'AppealsApi::SupplementalClaimUploadStatusBatch') # Update SupplementalClaim statuses with their Central Mail status - mgr.register('45 0 * * *', 'AppealsApi::HigherLevelReviewCleanUpWeekOldPii') - # Remove PII of HigherLevelReviews that have 1) reached one of the 'completed' statuses and 2) are a week old - mgr.register('45 0 * * *', 'AppealsApi::NoticeOfDisagreementCleanUpWeekOldPii') - # Remove PII of NoticeOfDisagreements that have 1) reached one of the 'completed' statuses and 2) are a week old + mgr.register('45 0 * * *', 'AppealsApi::HigherLevelReviewCleanUpPii') + # Remove PII of HigherLevelReviews after they have been successfully processed by the VA + mgr.register('45 0 * * *', 'AppealsApi::NoticeOfDisagreementCleanUpPii') + # Remove PII of NoticeOfDisagreements after they have been successfully processed by the VA mgr.register('45 0 * * *', 'AppealsApi::SupplementalClaimCleanUpPii') - # Remove PII of SupplementalClaims that have 1) reached one of the 'completed' statuses and 2) are a week old + # Remove PII of SupplementalClaims after they have been successfully processed by the VA mgr.register('30 * * * *', 'AppealsApi::EvidenceSubmissionBackup') # Ensures that appeal evidence received "late" (after the appeal has reached "success") is submitted to Central Mail mgr.register('0 23 * * 1-5', 'AppealsApi::DecisionReviewReportDaily') diff --git a/modules/appeals_api/app/sidekiq/appeals_api/higher_level_review_clean_up_week_old_pii.rb b/modules/appeals_api/app/sidekiq/appeals_api/higher_level_review_clean_up_pii.rb similarity index 91% rename from modules/appeals_api/app/sidekiq/appeals_api/higher_level_review_clean_up_week_old_pii.rb rename to modules/appeals_api/app/sidekiq/appeals_api/higher_level_review_clean_up_pii.rb index 04ce5cf0f2d..502f4881d6e 100644 --- a/modules/appeals_api/app/sidekiq/appeals_api/higher_level_review_clean_up_week_old_pii.rb +++ b/modules/appeals_api/app/sidekiq/appeals_api/higher_level_review_clean_up_pii.rb @@ -3,7 +3,7 @@ require 'sidekiq' module AppealsApi - class HigherLevelReviewCleanUpWeekOldPii + class HigherLevelReviewCleanUpPii include Sidekiq::Job # Only retry for ~8 hours since the job is run daily sidekiq_options retry: 11, unique_for: 8.hours diff --git a/modules/appeals_api/app/sidekiq/appeals_api/notice_of_disagreement_clean_up_week_old_pii.rb b/modules/appeals_api/app/sidekiq/appeals_api/notice_of_disagreement_clean_up_pii.rb similarity index 90% rename from modules/appeals_api/app/sidekiq/appeals_api/notice_of_disagreement_clean_up_week_old_pii.rb rename to modules/appeals_api/app/sidekiq/appeals_api/notice_of_disagreement_clean_up_pii.rb index 8f0458572f1..3897f42bccb 100644 --- a/modules/appeals_api/app/sidekiq/appeals_api/notice_of_disagreement_clean_up_week_old_pii.rb +++ b/modules/appeals_api/app/sidekiq/appeals_api/notice_of_disagreement_clean_up_pii.rb @@ -3,7 +3,7 @@ require 'sidekiq' module AppealsApi - class NoticeOfDisagreementCleanUpWeekOldPii + class NoticeOfDisagreementCleanUpPii include Sidekiq::Job # Only retry for ~8 hours since the job is run daily sidekiq_options retry: 11, unique_for: 8.hours diff --git a/modules/appeals_api/spec/sidekiq/higher_level_review_clean_up_week_old_pii_spec.rb b/modules/appeals_api/spec/sidekiq/higher_level_review_clean_up_pii_spec.rb similarity index 92% rename from modules/appeals_api/spec/sidekiq/higher_level_review_clean_up_week_old_pii_spec.rb rename to modules/appeals_api/spec/sidekiq/higher_level_review_clean_up_pii_spec.rb index 2b2259ab44f..aa05d501df2 100644 --- a/modules/appeals_api/spec/sidekiq/higher_level_review_clean_up_week_old_pii_spec.rb +++ b/modules/appeals_api/spec/sidekiq/higher_level_review_clean_up_pii_spec.rb @@ -2,7 +2,7 @@ require 'rails_helper' -describe AppealsApi::HigherLevelReviewCleanUpWeekOldPii, type: :job do +describe AppealsApi::HigherLevelReviewCleanUpPii, type: :job do let(:service) { instance_double(AppealsApi::RemovePii) } describe '#perform' do diff --git a/modules/appeals_api/spec/sidekiq/notice_of_disagreement_clean_up_week_old_pii_spec.rb b/modules/appeals_api/spec/sidekiq/notice_of_disagreement_clean_up_pii_spec.rb similarity index 91% rename from modules/appeals_api/spec/sidekiq/notice_of_disagreement_clean_up_week_old_pii_spec.rb rename to modules/appeals_api/spec/sidekiq/notice_of_disagreement_clean_up_pii_spec.rb index 7869a012c71..03c8db2de30 100644 --- a/modules/appeals_api/spec/sidekiq/notice_of_disagreement_clean_up_week_old_pii_spec.rb +++ b/modules/appeals_api/spec/sidekiq/notice_of_disagreement_clean_up_pii_spec.rb @@ -2,7 +2,7 @@ require 'rails_helper' -describe AppealsApi::NoticeOfDisagreementCleanUpWeekOldPii, type: :job do +describe AppealsApi::NoticeOfDisagreementCleanUpPii, type: :job do let(:service) { instance_double(AppealsApi::RemovePii) } describe '#perform' do