From 75e866d551027aeb187eaaf39743aaeb12260395 Mon Sep 17 00:00:00 2001 From: Derrick Ellerbie Date: Fri, 10 Jan 2025 13:49:51 -0800 Subject: [PATCH] EZR: Use hash instead of array for zsf tags --- app/sidekiq/hca/ezr_submission_job.rb | 8 ++++---- spec/sidekiq/hca/ezr_submission_job_spec.rb | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/app/sidekiq/hca/ezr_submission_job.rb b/app/sidekiq/hca/ezr_submission_job.rb index 530461dce29..71ff191d8cb 100644 --- a/app/sidekiq/hca/ezr_submission_job.rb +++ b/app/sidekiq/hca/ezr_submission_job.rb @@ -11,10 +11,10 @@ class EzrSubmissionJob FORM_ID = '10-10EZR' VALIDATION_ERROR = HCA::SOAPParser::ValidationError STATSD_KEY_PREFIX = 'api.1010ezr' - DD_ZSF_TAGS = [ - 'service:healthcare-application', - 'function: 10-10EZR async form submission' - ].freeze + DD_ZSF_TAGS = { + service: 'healthcare-application', + function: '10-10EZR async form submission' + }.freeze # retry for 2d 1h 47m 12s # https://github.com/sidekiq/sidekiq/wiki/Error-Handling diff --git a/spec/sidekiq/hca/ezr_submission_job_spec.rb b/spec/sidekiq/hca/ezr_submission_job_spec.rb index ec7b97c3994..64bad81cc32 100644 --- a/spec/sidekiq/hca/ezr_submission_job_spec.rb +++ b/spec/sidekiq/hca/ezr_submission_job_spec.rb @@ -98,7 +98,6 @@ def expect_submission_failure_email_and_statsd_increments described_class.within_sidekiq_retries_exhausted_block(msg) do expect(VANotify::EmailJob).not_to receive(:perform_async) expect(StatsD).not_to receive(:increment).with('api.1010ezr.submission_failure_email_sent') - expect(StatsD).not_to receive(:increment).with('silent_failure_avoided_no_confirmation', tags:) end end end