diff --git a/modules/claims_api/lib/bgs_service/veteran_representative_service.rb b/modules/claims_api/lib/bgs_service/veteran_representative_service.rb index fedf3640e66..6ba29329ede 100644 --- a/modules/claims_api/lib/bgs_service/veteran_representative_service.rb +++ b/modules/claims_api/lib/bgs_service/veteran_representative_service.rb @@ -7,13 +7,12 @@ def bean_name end def create_veteran_representative(options) - # error VetRep cannot be null injected = convert_nil_values(options) body = Nokogiri::XML::DocumentFragment.parse <<~EOXML - + #{injected} - + EOXML make_request( @@ -37,6 +36,7 @@ def read_all_veteran_representatives(type_code:, ptcpnt_id:) #{type_code} EOXML + ret = make_request(endpoint: bean_name, namespaces: { 'data' => '/data' }, action: 'readAllVeteranRepresentatives', body:, key: 'VeteranRepresentativeReturnList', diff --git a/modules/claims_api/spec/lib/claims_api/bgs/veteran_representative_service/create_veteran_representative_request_spec.rb b/modules/claims_api/spec/lib/claims_api/bgs/veteran_representative_service/create_veteran_representative_request_spec.rb index c11e21a4f6a..f0c9979722e 100644 --- a/modules/claims_api/spec/lib/claims_api/bgs/veteran_representative_service/create_veteran_representative_request_spec.rb +++ b/modules/claims_api/spec/lib/claims_api/bgs/veteran_representative_service/create_veteran_representative_request_spec.rb @@ -47,7 +47,7 @@ 'city' => 'Bridgeport', 'claimantPtcpntId' => '182358', 'claimantRelationship' => nil, - 'formTypeCode' => '21-22', + 'formTypeCode' => '21-22 ', 'insuranceNumbers' => nil, 'limitationAlcohol' => 'false', 'limitationDrugAbuse' => 'false', @@ -76,7 +76,7 @@ 'claimantMiddleName' => nil, 'declinedBy' => nil, 'declinedReason' => nil, - 'secondaryStatus' => nil, + 'secondaryStatus' => 'Obsolete', 'veteranFirstName' => 'VERNON', 'veteranLastName' => 'WAGNER', 'veteranMiddleName' => nil, diff --git a/modules/claims_api/spec/lib/claims_api/v2/disability_compensation_validation_spec.rb b/modules/claims_api/spec/lib/claims_api/v2/disability_compensation_validation_spec.rb index a2e7ac06596..12b68a21935 100644 --- a/modules/claims_api/spec/lib/claims_api/v2/disability_compensation_validation_spec.rb +++ b/modules/claims_api/spec/lib/claims_api/v2/disability_compensation_validation_spec.rb @@ -497,7 +497,7 @@ def current_error_array }, 'federalActivation' => { 'activationDate' => '2023-10-01', - 'anticipatedSeparationDate' => '2024-12-20' + 'anticipatedSeparationDate' => '2028-12-20' } } end diff --git a/spec/support/vcr_cassettes/claims_api/bgs/veteran_representative_service/create_veteran_representative/valid_params.yml b/spec/support/vcr_cassettes/claims_api/bgs/veteran_representative_service/create_veteran_representative/valid_params.yml index eafca230145..4f49e7cc3ec 100644 --- a/spec/support/vcr_cassettes/claims_api/bgs/veteran_representative_service/create_veteran_representative/valid_params.yml +++ b/spec/support/vcr_cassettes/claims_api/bgs/veteran_representative_service/create_veteran_representative/valid_params.yml @@ -1,149 +1,5 @@ --- http_interactions: -- request: - method: get - uri: "/VDC/VeteranRepresentativeService?WSDL" - body: - encoding: US-ASCII - string: '' - headers: - User-Agent: - - - Accept-Encoding: - - gzip;q=1.0,deflate;q=0.6,identity;q=0.3 - Accept: - - "*/*" - response: - status: - code: 200 - message: OK - headers: - Date: - - Tue, 23 Apr 2024 19:07:13 GMT - Server: - - Apache - X-Frame-Options: - - SAMEORIGIN - Transfer-Encoding: - - chunked - Content-Type: - - text/xml;charset=utf-8 - Strict-Transport-Security: - - max-age=16000000; includeSubDomains; preload; - body: - encoding: UTF-8 - string: |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - recorded_at: Mon, 22 Apr 2024 19:27:37 GMT - request: method: post uri: "/VDC/VeteranRepresentativeService" @@ -152,50 +8,31 @@ http_interactions: string: | - - - - VAgovAPI - - - 127.0.0.1 - 281 - VAgovAPI - keyHere - keyHere - - - + + + + VAgovAPI + + + 127.0.0.1 + 281 + VAgovAPI + xUid + xKey + + + - - - - 21-22 - 3854909 - 182359 - 074 - false - false - false - false - false - false - true - Submitted - Recognized Veterans Service Organization - 182358 - 76 Crowther Ave - Bridgeport - 06605 - CT - 2024-04-22T19:27:37Z - - - + + + 21-223854909182359074falsefalsefalsefalsefalsefalsetrueSubmittedRecognized Veterans Service Organization18235876 Crowther AveBridgeport06605CT2024-04-22T19:27:37Z + + + headers: User-Agent: - - + - "" Content-Type: - text/xml;charset=UTF-8 Host: @@ -212,7 +49,7 @@ http_interactions: message: OK headers: Date: - - Tue, 23 Apr 2024 19:07:14 GMT + - Fri, 20 Dec 2024 18:22:42 GMT Server: - Apache X-Frame-Options: @@ -228,53 +65,9 @@ http_interactions: string: - - 76 Crowther Ave - - - true - Bridgeport - 182358 - - 21-22 - - false - false - false - false - - - - 074 - 06605 - 3854909 - - - - - Recognized Veterans Service Organization - false - - - CT - Submitted - 182359 - - VERNON - WAGNER - - - - - VERNON - WAGNER - - - - - - - - recorded_at: Mon, 22 Apr 2024 19:27:37 GMT -recorded_with: VCR 6.2.0 + xmlns:ns2="http://gov.va.vba.benefits.vdc/data">76 + Crowther AvetrueBridgeport18235821-22 + falsefalsefalsefalse074066053854909Recognized + Veterans Service OrganizationfalseCTSubmitted182359VERNONWAGNERObsoleteVERNONWAGNER + recorded_at: Fri, 20 Dec 2024 18:22:42 GMT +recorded_with: VCR 6.3.1