From 2edde0acdcbf21a9acf35f374e3bd2af6fb4a4b0 Mon Sep 17 00:00:00 2001 From: Oren Mittman Date: Mon, 30 Dec 2024 19:00:56 -0500 Subject: [PATCH] [ART] lint fixes --- .../power_of_attorney_form.rb | 1 - .../power_of_attorney_request.rb | 2 +- .../v0/power_of_attorney_requests_spec.rb | 84 +++++++++---------- 3 files changed, 43 insertions(+), 44 deletions(-) diff --git a/modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_form.rb b/modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_form.rb index d3d034b98d0..8f1115b504c 100644 --- a/modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_form.rb +++ b/modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_form.rb @@ -6,7 +6,6 @@ class PowerOfAttorneyForm < ApplicationRecord class_name: 'AccreditedRepresentativePortal::PowerOfAttorneyRequest', inverse_of: :power_of_attorney_form - has_kms_key has_encrypted( diff --git a/modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request.rb b/modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request.rb index 399ff936876..a7db8664312 100644 --- a/modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request.rb +++ b/modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request.rb @@ -30,7 +30,7 @@ def set_claimant_type if power_of_attorney_form.parsed_data['veteran'] self.claimant_type = ClaimantTypes::VETERAN - return + nil end end end diff --git a/modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb b/modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb index d4b59a09326..69f22b7bea3 100644 --- a/modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb +++ b/modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb @@ -296,54 +296,54 @@ 'claimant_id' => poa_request.claimant_id, 'claimant_type' => 'dependent', 'created_at' => time, - "power_of_attorney_form" => { - "authorizations" => { - "record_disclosure" => true, - "record_disclosure_limitations" => [], - "address_change" => true + 'power_of_attorney_form' => { + 'authorizations' => { + 'record_disclosure' => true, + 'record_disclosure_limitations' => [], + 'address_change' => true }, - "dependent" => { - "name" => { - "first" => "John", - "middle" => "Middle", - "last" => "Doe" + 'dependent' => { + 'name' => { + 'first' => 'John', + 'middle' => 'Middle', + 'last' => 'Doe' }, - "address" => { - "address_line1" => "123 Main St", - "address_line2" => "Apt 1", - "city" => "Springfield", - "state_code" => "IL", - "country" => "US", - "zip_code" => "62704", - "zip_code_suffix" => "6789" + 'address' => { + 'address_line1' => '123 Main St', + 'address_line2' => 'Apt 1', + 'city' => 'Springfield', + 'state_code' => 'IL', + 'country' => 'US', + 'zip_code' => '62704', + 'zip_code_suffix' => '6789' }, - "date_of_birth" => "1980-12-31", - "relationship" => "Spouse", - "phone" => "1234567890", - "email" => "veteran@example.com" + 'date_of_birth' => '1980-12-31', + 'relationship' => 'Spouse', + 'phone' => '1234567890', + 'email' => 'veteran@example.com' }, - "veteran" => { - "name" => { - "first" => "John", - "middle" => "Middle", - "last" => "Doe" + 'veteran' => { + 'name' => { + 'first' => 'John', + 'middle' => 'Middle', + 'last' => 'Doe' }, - "address" => { - "address_line1" => "123 Main St", - "address_line2" => "Apt 1", - "city" => "Springfield", - "state_code" => "IL", - "country" => "US", - "zip_code" => "62704", - "zip_code_suffix" => "6789" + 'address' => { + 'address_line1' => '123 Main St', + 'address_line2' => 'Apt 1', + 'city' => 'Springfield', + 'state_code' => 'IL', + 'country' => 'US', + 'zip_code' => '62704', + 'zip_code_suffix' => '6789' }, - "ssn" => "123456789", - "va_file_number" => "123456789", - "date_of_birth" => "1980-12-31", - "service_number" => "123456789", - "service_branch" => "ARMY", - "phone" => "1234567890", - "email" => "veteran@example.com" + 'ssn' => '123456789', + 'va_file_number' => '123456789', + 'date_of_birth' => '1980-12-31', + 'service_number' => '123456789', + 'service_branch' => 'ARMY', + 'phone' => '1234567890', + 'email' => 'veteran@example.com' } }, 'resolution' => {