Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement POA Request Detail API Endpoint #98709

Open
2 tasks
nihil2501 opened this issue Dec 10, 2024 · 1 comment
Open
2 tasks

Implement POA Request Detail API Endpoint #98709

nihil2501 opened this issue Dec 10, 2024 · 1 comment
Assignees
@ojbucao
Labels
accredited-rep-facing Accredited Representative Facing Team backend engineering Engineering topics

Comments

@nihil2501
Copy link
Contributor

nihil2501 commented Dec 10, 2024 •
edited
Loading

Description

Replace the current mock data implementation with one that serializes the result of a pundit-scoped POA request DB query.

Implementation Details

Outcomes:

  • 200
  • 404
  • 401
  • Probably no 403 for security (don't reveal the existence of a POA request that the user is not authorized to act on when guessing ID)

Include POA request with its extended object graph:

  • Claimant
  • Veteran
  • POA holder membership
    • Accredited individual
    • POA holder
  • Resolution
  • Authorizations

Blockers

POA holder membership data model hasn't been modeled yet.

Acceptance Criteria/Conditions of Satisfaction

  • See real DB data surfaced in API response

Automated Testing

  • Request spec for the above status code outcomes
@nihil2501 nihil2501 added accredited-rep-facing Accredited Representative Facing Team arf-eng backend labels Dec 10, 2024
@nihil2501 nihil2501 changed the title Implement POA Request Show API Endpoint Implement POA Request Detail API Endpoint Dec 10, 2024
@candilemoine candilemoine added engineering Engineering topics and removed arf-eng labels Dec 18, 2024
@ojbucao
Copy link

ojbucao commented Dec 19, 2024

PR department-of-veterans-affairs/vets-api#19967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ojbucao ojbucao

Labels
accredited-rep-facing Accredited Representative Facing Team backend engineering Engineering topics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nihil2501 @ojbucao @candilemoine