Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD: Look into submissions from frontend to backend #98335

Open
9 of 15 tasks
digitaldrk opened this issue Dec 4, 2024 · 2 comments
Open
9 of 15 tasks

DD: Look into submissions from frontend to backend #98335

digitaldrk opened this issue Dec 4, 2024 · 2 comments
Assignees
Labels
vsa-debt Benefits Team 2 (formerly Debt Resolution,Benefits and Memorials 2)

Comments

@digitaldrk
Copy link
Contributor

digitaldrk commented Dec 4, 2024

Issue Description

Given: The frontend (vets-website) submits form data to the backend (vets-api)
When: The frontend code is merged in and the frontend is able to submit forms
Then: We must inspect the data coming from vets-website to vets-api and possibly make changes to the vets-api code including hardening validation and maybe changing what vets-api's expectations of what will be sent to what is actually being sent.

Tasks

  • Look into payload coming from frontend, make adjustments to backend to accommodate the frontend's payload
  • Look into using the JSON::Schema library for validation

Design and Front End sync on implementation of design

  • Required
  • Complete
  • Not Required

Acceptance Criteria

  • All changes necessary to successfully accept and validate data coming from vets-website are made.

Testing

  • N/A if non development work
  • Testing passed and documented in this ticket based off the "Then" statement in the description

Test procedures:
If additional testing steps or credentials to perform testing are needed list them here

Ticket Creation - Definition of Ready

  • Description written
  • Tasks defined
  • Acceptance criteria written
  • Testing defined
  • Add Labels
  • Attach to an Epic
  • Estimate Points
@digitaldrk digitaldrk self-assigned this Dec 4, 2024
@digitaldrk digitaldrk added backend digital-dispute Changes relating to Digital Dispute form - debt resolution team vsa-debt Benefits Team 2 (formerly Debt Resolution,Benefits and Memorials 2) blocked labels Dec 4, 2024
@digitaldrk
Copy link
Contributor Author

Marking this as blocked until we get the FE PR merged

@digitaldrk
Copy link
Contributor Author

Still blocked, we had to merge another PR before the FE PR could get merged

@Tom-Davis Tom-Davis removed backend blocked digital-dispute Changes relating to Digital Dispute form - debt resolution team labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vsa-debt Benefits Team 2 (formerly Debt Resolution,Benefits and Memorials 2)
Projects
None yet
Development

No branches or pull requests

2 participants